From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
 by sourceware.org (Postfix) with ESMTP id C8E05385741A
 for <gdb-patches@sourceware.org>; Tue,  8 Jun 2021 01:15:37 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C8E05385741A
Received: from vapier (localhost [127.0.0.1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by smtp.gentoo.org (Postfix) with ESMTPS id 01978335CA3;
 Tue,  8 Jun 2021 01:15:36 +0000 (UTC)
Date: Mon, 7 Jun 2021 21:15:36 -0400
From: Mike Frysinger <vapier@gentoo.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] gnulib: import chown
Message-ID: <YL7EuIgTvd9QZ/9k@vapier>
Mail-Followup-To: Eli Zaretskii <eliz@gnu.org>, Tom Tromey <tom@tromey.com>,
 gdb-patches@sourceware.org
References: <20210529172510.16285-1-vapier@gentoo.org>
 <87k0n5n47d.fsf@tromey.com> <83sg1tg2zp.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <83sg1tg2zp.fsf@gnu.org>
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jun 2021 01:15:48 -0000

On 07 Jun 2021 17:31, Eli Zaretskii via Gdb-patches wrote:
> > From: Tom Tromey <tom@tromey.com>
> > Date: Mon, 07 Jun 2021 08:23:50 -0600
> > 
> > >>>>> "Mike" == Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org> writes:
> > 
> > Mike> A few sims use this to emulate chown syscalls.
> > 
> > Looks good.
> 
> AFAICT, the Gnulib emulation always returns a failure status in the
> MinGW port, is that okay for the callers of chown?  Perhaps a better
> alternative is to silently do nothing on MS-Windows?

the calling code can decide how to handle this.  using gnulib is still better
so we don't have to put _WIN32/__MINGW32__/whatever ifdefs everywhere.
-mike