From: Mike Frysinger <vapier@gentoo.org>
To: Tom Tromey <tom@tromey.com>
Cc: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gnulib: allow control over srcdir
Date: Wed, 9 Jun 2021 12:58:12 -0400 [thread overview]
Message-ID: <YMDzJDvaYpDkFRkV@vapier> (raw)
In-Reply-To: <87czsvjdr6.fsf@tromey.com>
On 09 Jun 2021 08:47, Tom Tromey wrote:
> >>>>> "Mike" == Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Mike> The current setting assumes that gnulib is only used by dirs
> Mike> immediately under the source root. Trying to build it two or
> Mike> more levels deep fails. Add a variable so users can control.
>
> This is ok.
i noticed an issue. upstream gnulib already uses GNULIB_SRCDIR in its bootstrap
so people can export it in their env to point to the upstream gnulib git tree.
if that's exported, then building gdb fails :/.
since we can't assume GNU make, i was going to rename it to GNULIB_LOCAL_SRCDIR
unless someone wants to bikeshed a diff name.
> This file isn't actually used any more by gdb.
seems to be ? gdb/Makefile.in & gdbserver/Makefile.in have:
gdb/Makefile.in:GNULIB_BUILDDIR = ../gnulib
gdb/Makefile.in:include $(GNULIB_BUILDDIR)/Makefile.gnulib.inc
gdb/Makefile.in: $(INTL_CFLAGS) $(INCGNU) $(INCSUPPORT) $(ENABLE_CFLAGS) \
gdb/Makefile.in: $(WIN32LIBS) $(LIBGNU) $(LIBGNU_EXTRA_LIBS) $(LIBICONV) \
gdb/Makefile.in: $(OPCODES) $(INTL_DEPS) $(LIBIBERTY) $(CONFIG_DEPS) $(LIBGNU) \
gdbserver/Makefile.in:GNULIB_BUILDDIR = ../gnulib
gdbserver/Makefile.in:include $(GNULIB_BUILDDIR)/Makefile.gnulib.inc
gdbserver/Makefile.in: -I$(srcdir)/../gdb $(INCGNU) $(INCSUPPORT) \
gdbserver/Makefile.in:gdbserver$(EXEEXT): $(sort $(OBS)) ${CDEPS} $(LIBGNU) $(LIBIBERTY) \
gdbserver/Makefile.in: -o gdbserver$(EXEEXT) $(OBS) $(GDBSUPPORT) $(LIBGNU) \
gdbserver/Makefile.in: $(LIBGNU_EXTRA_LIBS) $(LIBIBERTY) $(INTL) \
gdbserver/Makefile.in:gdbreplay$(EXEEXT): $(sort $(GDBREPLAY_OBS)) $(LIBGNU) $(LIBIBERTY) \
gdbserver/Makefile.in: $(GDBSUPPORT) $(LIBGNU) $(LIBGNU_EXTRA_LIBS) \
-mike
next prev parent reply other threads:[~2021-06-09 16:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 22:06 Mike Frysinger
2021-06-09 14:47 ` Tom Tromey
2021-06-09 16:58 ` Mike Frysinger [this message]
2021-06-10 18:15 ` Tom Tromey
2021-06-13 5:23 ` [PATCH] gnulib: define the path to gnulib's parent dir Mike Frysinger
2021-06-14 15:23 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMDzJDvaYpDkFRkV@vapier \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).