Re: [PATCH 4/4] gnulib: import select

[Mike Frysinger <vapier@gentoo.org>]

On 09 Jun 2021 19:12, Pedro Alves wrote:
> On 2021-06-09 5:52 p.m., Mike Frysinger wrote:
> > On 09 Jun 2021 13:27, Pedro Alves wrote:
> >> I've always feared that gnulib's select module would conflict with that,
> >> but I don't know for sure.  In theory, we should be able to replace all
> >> that code by using gnulib's select instead, though I'm not sure gnulib
> >> handles some particulars like Ctrl-C interruption.
> > 
> > why do you think it would conflict ?  the file doesn't seem to use select()
> > at all, and ser-mingw is always enabled for mingw targets.  seems like the
> > func would just be ignored.
> 
> gnulib also sometimes replaces headers with their own incompatible
> definitions.

good point, but i'm not sure how that matters to ser-mingw specifically.
it isn't including any select.h related headers, just Windows-specific ones.
i haven't gone through that list (and indirect includes) explicitly.  but i
would expect the build to at least warn or fail if that were the case.

did you have any specific concerns here ?  or just aiming for due diligence
with the testsuite to assuage general unease ?
-mike