Re: [PATCH] gnulib: import sys_wait

[Mike Frysinger <vapier@gentoo.org>]

On 14 Jun 2021 17:43, Eli Zaretskii wrote:
> > Date: Mon, 14 Jun 2021 10:35:07 -0400
> > From: Mike Frysinger <vapier@gentoo.org>
> > Cc: gdb-patches@sourceware.org
> > 
> > > AFAIU, this conflicts with what we have in gdbsupport/gdb_wait.h and
> > > use in windows-nat.c and win32-low.cc.  Worse, the Gnulib emulation of
> > > this for Windows is (IMNSHO) less useful, since it doesn't support any
> > > abnormal termination except the equivalent of SIGABRT (which causes
> > > the Windows runtime to exit with status = 3).  I tried to convince the
> > > Gnulib folks to adopt a more useful emulation, similar to what we have
> > > in gdb_wait.h, but AFAIR Bruno Haible rejected the idea.
> > 
> > i don't think there's any conflicts.  gdb* dirs probe the env w/out gnulib,
> > so they'll see sys/wait.h is not available, and then the gdb_wait.h and such
> > files will continue to be used.
> > 
> > > Did you need this Gnulib module because those sims don't use
> > > gdbsupport?  And if so, is it possible to somehow avoid clashes
> > > between this Gnulib module and what we have in gdb_wait.h?
> > 
> > sim/ doesn't use gdbsupport/.  the gdbsupport/ dir assumes it's used with
> > only gdb/, and is C++, so i don't think trying to generalize it is worth
> > the effort.
> 
> OK, if there are no conflicts here, then apologies for the noise.  (I
> never build the sim subdirectory in my builds of GDB.)

np, it's good to double check these nuances

i've verified that gdb & gdbsupport don't detect sys/wait.h for a mingw build,
and the gdb_wait file is compiled.  i don't have a way of checking the gdb.exe
though.
-mike