From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (mail.gentoo.org
 [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
 by sourceware.org (Postfix) with ESMTP id 60BD938515EB
 for <gdb-patches@sourceware.org>; Mon, 14 Jun 2021 19:35:16 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 60BD938515EB
Received: from vapier (localhost [127.0.0.1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by smtp.gentoo.org (Postfix) with ESMTPS id 5A033335CD4;
 Mon, 14 Jun 2021 19:35:15 +0000 (UTC)
Date: Mon, 14 Jun 2021 15:35:14 -0400
From: Mike Frysinger <vapier@gentoo.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gnulib: import sys_wait
Message-ID: <YMevchkUu5wPehIK@vapier>
Mail-Followup-To: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
References: <20210613052519.19005-1-vapier@gentoo.org> <834ke07i7y.fsf@gnu.org>
 <YMdpGwJPJOBR/Efe@vapier> <83v96g5wxg.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <83v96g5wxg.fsf@gnu.org>
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Jun 2021 19:35:18 -0000

On 14 Jun 2021 17:43, Eli Zaretskii wrote:
> > Date: Mon, 14 Jun 2021 10:35:07 -0400
> > From: Mike Frysinger <vapier@gentoo.org>
> > Cc: gdb-patches@sourceware.org
> > 
> > > AFAIU, this conflicts with what we have in gdbsupport/gdb_wait.h and
> > > use in windows-nat.c and win32-low.cc.  Worse, the Gnulib emulation of
> > > this for Windows is (IMNSHO) less useful, since it doesn't support any
> > > abnormal termination except the equivalent of SIGABRT (which causes
> > > the Windows runtime to exit with status = 3).  I tried to convince the
> > > Gnulib folks to adopt a more useful emulation, similar to what we have
> > > in gdb_wait.h, but AFAIR Bruno Haible rejected the idea.
> > 
> > i don't think there's any conflicts.  gdb* dirs probe the env w/out gnulib,
> > so they'll see sys/wait.h is not available, and then the gdb_wait.h and such
> > files will continue to be used.
> > 
> > > Did you need this Gnulib module because those sims don't use
> > > gdbsupport?  And if so, is it possible to somehow avoid clashes
> > > between this Gnulib module and what we have in gdb_wait.h?
> > 
> > sim/ doesn't use gdbsupport/.  the gdbsupport/ dir assumes it's used with
> > only gdb/, and is C++, so i don't think trying to generalize it is worth
> > the effort.
> 
> OK, if there are no conflicts here, then apologies for the noise.  (I
> never build the sim subdirectory in my builds of GDB.)

np, it's good to double check these nuances

i've verified that gdb & gdbsupport don't detect sys/wait.h for a mingw build,
and the gdb_wait file is compiled.  i don't have a way of checking the gdb.exe
though.
-mike