From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id DDB783858D39 for ; Wed, 20 Oct 2021 21:15:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DDB783858D39 Received: by mail-pl1-x62a.google.com with SMTP id s1so15209606plg.12 for ; Wed, 20 Oct 2021 14:15:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VmyayghHBg6tIEVLL0c4Urgdn8cTT3ai2DDLtC/WPNA=; b=T+iy99C7Ex4/Tqg/bB/6Cv6UtE0jZVbhivNUoOhb5dHb3G/S9KDygKORMaxD0w7p6d +mc8U9AbTTmvvRQdTHnkpMKkHRBXdyANH8Ndps9qKK5XfzDzAZMrrfrXuqTW79FKJ+4X rO75Kd+pBZn+FSW42PMz1QvPWPOJwMpQKFK+x87GRuJywy0uNoiIt/vQqb1usxUxWv5O NvFQOJ1sJ6MElOdp4ouD1WuNvvmpm/PQMOVJBDzQbjnCPPY/5SkD7iP5AZIgHSE6zN8j +KUAI0cXm3yuelIJVnegDKXRgPngFwGTx3P7hLkt6AwF0zQHbfvmwmNLXs8rL3v+Nra/ 2AkQ== X-Gm-Message-State: AOAM5324U2JyY6HjB+P3qOcn9lYeJg5LqFZPlonE/nIL2Z1S6efZioR3 6cfFF/FA9ITH0gMg0fE4uBg= X-Google-Smtp-Source: ABdhPJxNlvfgtrEjzDQjLXvaYFDlZJWnoZG4O9gPGAYI0/6q1U6bRxb9UCtwpSLg3UBNZvnQusl0Hw== X-Received: by 2002:a17:902:d488:b0:13f:165e:f491 with SMTP id c8-20020a170902d48800b0013f165ef491mr1519997plg.12.1634764511580; Wed, 20 Oct 2021 14:15:11 -0700 (PDT) Received: from localhost ([2409:10:24a0:4700:e8ad:216a:2a9d:6d0c]) by smtp.gmail.com with ESMTPSA id r19sm3598942pfh.14.2021.10.20.14.15.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 14:15:10 -0700 (PDT) Date: Thu, 21 Oct 2021 06:15:09 +0900 From: Stafford Horne To: Tom Tromey Cc: Stafford Horne via Gdb-patches , Openrisc Subject: Re: [PATCH 0/5] OpenRISC Linux Native and GDBServer Support Message-ID: References: <20210913124800.471680-1-shorne@gmail.com> <87ee8fv9ql.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ee8fv9ql.fsf@tromey.com> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2021 21:15:14 -0000 On Wed, Oct 20, 2021 at 12:20:34PM -0600, Tom Tromey wrote: > >>>>> ">" == Stafford Horne via Gdb-patches writes: > > >> Hello, > >> As I have been working on the OpenRISC glibc port over the last few years now I > >> have had the need to have Linux native debugging. At first I started with the > >> gdbserver, but quickly grew out of that and just settled on running gdb native > >> on the platform. > > I read through these and it seemed basically ok to me. I sent one > little nit. I don't think it needs re-review if you want to fix that. Thanks for reviewing. I will give it a day or two for more comments before pushing upstream. -Stafford