From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 49FEF3858C27 for ; Sun, 21 Nov 2021 13:03:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 49FEF3858C27 Received: by mail-wm1-x333.google.com with SMTP id n33-20020a05600c502100b0032fb900951eso14384958wmr.4 for ; Sun, 21 Nov 2021 05:03:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PliKr0fW3kHp+0ejn76h7YESJvktPd2DSPewh0SudB4=; b=CiK4fUkyHZ+A6PTTq5roaJU2btLN1QuVorGZs/kNLlj0BgPGLOtmbFjxfwC9F70zk9 v4QGdlpVbp1zW0+6jVagiCn3RV16L/lc8f7HWHdg/ICZ5YLsPf2V+EkKWbp5NdMNAvLp KiG/b68K4GT9uR7wOAItkL1Z3ilJLMmPIXdVfLGRviU2gN40HCxmnw8wqmxikoqXQn+N J7rPrTsP6+vF32XdhkUAGopd8mewp7VvTuNa5UZCCTENtpKjxCSy/fUEeqep8M90Grhs /y2GcHFLG7TJb0L88PwK/lp9zKDzilJZ/UAu1YwgMNRncFbeCX4AvMPsQyqlKPz+FqPw bDBA== X-Gm-Message-State: AOAM532lirR7tgBTIUcxthPI9sDxBN2IlFqwJ0E8gvgn/3QsFjyjV3Z5 sk27zZFBz2DVsUKqUYdAoVYx X-Google-Smtp-Source: ABdhPJzOSCpEyfa9QmQ4KgSwuLfsNF5Tb8Q/XQw5SXI981+TZlH8wRJMSgwgeOUIWxwtfG/UBtRjQA== X-Received: by 2002:a7b:cf0f:: with SMTP id l15mr19746649wmg.92.1637499805384; Sun, 21 Nov 2021 05:03:25 -0800 (PST) Received: from takamaka.home ([2a01:cb22:1d5:1100:e567:702d:5b97:33e7]) by smtp.gmail.com with ESMTPSA id u2sm6852209wrs.17.2021.11.21.05.03.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Nov 2021 05:03:24 -0800 (PST) Received: by takamaka.home (Postfix, from userid 1000) id E16E6A15C7; Sun, 21 Nov 2021 17:03:21 +0400 (+04) Date: Sun, 21 Nov 2021 17:03:21 +0400 From: Joel Brobecker To: Simon Marchi Cc: Enze Li , gdb-patches@sourceware.org, Joel Brobecker Subject: Re: [PATCH] gdb: AC_INIT should be called with package and version arguments Message-ID: References: <6b270217-7410-9ae2-cfeb-a05c158704c2@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6b270217-7410-9ae2-cfeb-a05c158704c2@polymtl.ca> X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Nov 2021 13:03:28 -0000 Hi Enze Li, hi Simon, On Sun, Nov 14, 2021 at 09:52:00PM -0500, Simon Marchi wrote: > On 2021-11-13 23:09, Enze Li via Gdb-patches wrote: > > This patch adds package and version parameters to AC_INIT and > > regenerates the configure script. > > Just wondering, is there practical reason to change this other than to > "do things right"? I'm not against it, I would just like to know the > motivation behind it. > > > diff --git a/gdb/version.m4 b/gdb/version.m4 > > new file mode 100644 > > index 00000000000..2fa57f680ef > > --- /dev/null > > +++ b/gdb/version.m4 > > @@ -0,0 +1 @@ > > +m4_define([GDB_VERSION], [12.0.50]) > > > > We already have the version number in gdb/version.in. I don't know if > we want to hardcode it at two places. At least, this should be > coordinated with Joel, responsible for the release process including > bumping the version number. Agreed. Can we have the configure script get the information from gdb/version.in? -- Joel