From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 67AEC3858404 for ; Sat, 4 Dec 2021 10:43:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 67AEC3858404 Received: by mail-wr1-x42a.google.com with SMTP id d24so11410943wra.0 for ; Sat, 04 Dec 2021 02:43:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=M4FR9ikGsMIdV87+gCy0Oddo0a7VDx3ChfClOdFwpSc=; b=y2YyMAYJZGGq0/uc9zbTFBvQZWkkpugaAXoB4DLU7Ipcv5+Kpb8in5W8KT2Q8KIcP8 gDBVTci/LJuEWl+PJjhEye2/T/G3uqTxuQl7AvGRpoyi4lkWBk7BVcW++hpd3hP+HWEB I6feXFWyqyCUbgyJDsf6DPb4kl46VTJziAx6T7zQOQU8bn0I+Ob4UTiOJLkqniR6zlYy fhmeGkWdUJ5uRXg2nl3SxkrKX9MVfM0aME49i2750TyJo2GgrTj32wtrObIDpYcR3gNZ FwGemP9JBQSuxUylS/Qh1qZED8kq2RaCCWGY1Kyu3PrOQPzdGqe4xEiuUvBd/c8j9fsN o9PA== X-Gm-Message-State: AOAM533loKdaRXH4WZF93tX0vssI2W6Qa/zmT1zrGXiMslFO38yjMN9N Fl74+EChf63myRMaDXvuTiee X-Google-Smtp-Source: ABdhPJz8K3uveQ9/qLHrkA38Jg+l7sd8jhBQlxMD1yCW03WajERnvc253lShw3NcSn07pu2DyRsdyw== X-Received: by 2002:adf:ce08:: with SMTP id p8mr28641355wrn.154.1638614590501; Sat, 04 Dec 2021 02:43:10 -0800 (PST) Received: from takamaka.home ([2a01:cb22:1d5:1100:189d:8d55:3ad5:13d3]) by smtp.gmail.com with ESMTPSA id 4sm6812082wrz.90.2021.12.04.02.43.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Dec 2021 02:43:10 -0800 (PST) Received: by takamaka.home (Postfix, from userid 1000) id B2881A5A43; Sat, 4 Dec 2021 14:43:07 +0400 (+04) Date: Sat, 4 Dec 2021 14:43:07 +0400 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org, Joel Brobecker Subject: Re: [PATCH 1/3] Remove Irix case from find_file_and_directory Message-ID: References: <20211130013304.4135367-1-tom@tromey.com> <20211130013304.4135367-2-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211130013304.4135367-2-tom@tromey.com> X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Dec 2021 10:43:12 -0000 > find_file_and_directory has a special case for the Irix 6.2 compiler. > Since this is long obsolete, this patch removes it. Looks good to me. Thanks Tom! > --- > gdb/dwarf2/read.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c > index 57538fc0adf..3cf0c9ea2a8 100644 > --- a/gdb/dwarf2/read.c > +++ b/gdb/dwarf2/read.c > @@ -10509,15 +10509,6 @@ find_file_and_directory (struct die_info *die, struct dwarf2_cu *cu) > res.comp_dir > = cu->per_objfile->objfile->intern (comp_dir_storage.c_str ()); > } > - if (res.comp_dir != NULL) > - { > - /* Irix 6.2 native cc prepends .: to the compilation > - directory, get rid of it. */ > - const char *cp = strchr (res.comp_dir, ':'); > - > - if (cp && cp != res.comp_dir && cp[-1] == '.' && cp[1] == '/') > - res.comp_dir = cp + 1; > - } > > if (res.name == NULL) > res.name = ""; > -- > 2.31.1 > -- Joel