From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tom@tromey.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Allow DW_ATE_UTF for Rust characters
Date: Sat, 4 Dec 2021 15:23:50 +0400 [thread overview]
Message-ID: <YatPxvvEmiy6OlJ9@adacore.com> (raw)
In-Reply-To: <87o86296uc.fsf@tromey.com>
Hi Tom,
> >> Changing this code to use a character type revealed a couple of
> >> oddities in the C/C++ handling of TYPE_CODE_CHAR. This patch fixes
> >> these as well.
>
> Joel> I don't see any real problem with this patch, and in particular
> Joel> the change in dwarf2/read.c looks good to me. But I couldn't
> Joel> really grasp what the oddities you are referring to were, and
> Joel> so I don't understand the changes in c-lang.c and c-valprint.c
> Joel> Can you tell us more about them?
>
> Sure thing, will do so inline, below.
Thanks for the extra explanations. I understand the patch, now, and
it looks to me.
--
Joel
prev parent reply other threads:[~2021-12-04 11:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-31 17:17 Tom Tromey
2021-11-10 19:57 ` Tom Tromey
2021-11-21 13:33 ` Joel Brobecker
2021-11-29 18:04 ` Tom Tromey
2021-12-04 11:23 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YatPxvvEmiy6OlJ9@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).