From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (dev.gentoo.org
 [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
 by sourceware.org (Postfix) with ESMTP id D0FA53858416
 for <gdb-patches@sourceware.org>; Wed, 12 Jan 2022 10:06:06 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D0FA53858416
Received: by smtp.gentoo.org (Postfix, from userid 559)
 id 44027342B41; Wed, 12 Jan 2022 10:06:05 +0000 (UTC)
Date: Wed, 12 Jan 2022 05:06:03 -0500
From: Mike Frysinger <vapier@gentoo.org>
To: Dragan Mladjenovic <Dragan.Mladjenovic@syrmia.com>
Cc: gdb-patches@sourceware.org, "Maciej W . Rozycki" <macro@orcam.me.uk>,
 Chao-ying Fu <cfu@wavecomp.com>,
 Faraz Shahbazker <fshahbazker@wavecomp.com>
Subject: Re: [PATCH v3 1/4] sim: Allow toggling of quiet NaN-bit semantics
Message-ID: <Yd6oC7lCe7lsdItb@vapier>
Mail-Followup-To: Dragan Mladjenovic <Dragan.Mladjenovic@syrmia.com>,
 gdb-patches@sourceware.org,
 "Maciej W . Rozycki" <macro@orcam.me.uk>,
 Chao-ying Fu <cfu@wavecomp.com>,
 Faraz Shahbazker <fshahbazker@wavecomp.com>
References: <20220111212406.32312-1-Dragan.Mladjenovic@syrmia.com>
 <20220111212406.32312-2-Dragan.Mladjenovic@syrmia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="SQTSGLjNXJIWs6EM"
Content-Disposition: inline
In-Reply-To: <20220111212406.32312-2-Dragan.Mladjenovic@syrmia.com>
X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Jan 2022 10:06:10 -0000


--SQTSGLjNXJIWs6EM
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 11 Jan 2022 22:24, Dragan Mladjenovic wrote:
> --- a/sim/common/sim-fpu.h
> +++ b/sim/common/sim-fpu.h
> =20
> +/* Toggle quiet NaN semantics.  */
> =20
> +extern bool sim_fpu_quiet_nan_inverted;

please avoid global variables.  this should be part of sim_fpu state instea=
d.

also, include stdbool.h in the header since you're adding that type.
-mike

--SQTSGLjNXJIWs6EM
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmHeqAsACgkQQWM7n+g3
9YEykw//dXUrQxyzKMkQFXkytji7yQKvmmZQXpk8o/n9WeXIGX7TbaCz+MfZQ2Mu
JDYkqy90w27bvdCViNTKEpae7Y1aB4swnvGGIC+MK2i55X3MBHQ5Mk9TpSJf3QsI
/x433DAifyaav/B6AXwYJXQ7Na3CaXZhLSrPaHzdbRGNGGuj1aRFUyPjVzmHQuu4
/ebzfOkVq1kCywuD0+gUjHTpFd9eeaOvwqonNscDLJpHT1MqrzKm7Bn6+3JeFVyQ
RRqlSgPeS366qMk+FI7R4IXKVkCi8ciZwjh8IlenX7hqS2rMutZreaOJNZAjCOQB
9xpXiwEnFbIKcmx+ZJxJAy9DArUYec4rCLodR+coXORkwvB/yIAKWuLPL9ku46jq
GVIjXO/AMW40qEN482Xyo6wRFxUTd6fekqKjKYdAXM0jUrFQHfY2gCpFCSa9Xll8
ANIVNMwAO0ujnkFhHyMDFYIMuYBpURwddAzwrnPGj5NyBghyM+DBZU+9aNWZPOxZ
8MEcSjGcL+F3jyyU60AhMyMJuf9YvcexZjAHjCuEfjZQ+DjprgsAq5CvXyXynTkT
RTUVbKC6CF63ahOZUut0v6lFpt/ej7n4KhazPRJzxCxYu/uJ7Ma7QBVDxCT623wG
pzpIoV75xYoPuXbJdaNJIBe9TIcXPaLufj/ltDbLkl7NH9P//4c=
=BnsF
-----END PGP SIGNATURE-----

--SQTSGLjNXJIWs6EM--