From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 3879C3858416 for ; Wed, 12 Jan 2022 10:45:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3879C3858416 Received: by smtp.gentoo.org (Postfix, from userid 559) id B76EB342E02; Wed, 12 Jan 2022 10:45:00 +0000 (UTC) Date: Wed, 12 Jan 2022 05:44:58 -0500 From: Mike Frysinger To: Dragan Mladjenovic , gdb-patches@sourceware.org, "Maciej W . Rozycki" , Chao-ying Fu , Faraz Shahbazker Subject: Re: [PATCH v3 1/4] sim: Allow toggling of quiet NaN-bit semantics Message-ID: Mail-Followup-To: Dragan Mladjenovic , gdb-patches@sourceware.org, "Maciej W . Rozycki" , Chao-ying Fu , Faraz Shahbazker References: <20220111212406.32312-1-Dragan.Mladjenovic@syrmia.com> <20220111212406.32312-2-Dragan.Mladjenovic@syrmia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vTQ7TDy92zOavu51" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jan 2022 10:45:02 -0000 --vTQ7TDy92zOavu51 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 12 Jan 2022 05:06, Mike Frysinger via Gdb-patches wrote: > On 11 Jan 2022 22:24, Dragan Mladjenovic wrote: > > --- a/sim/common/sim-fpu.h > > +++ b/sim/common/sim-fpu.h > > =20 > > +/* Toggle quiet NaN semantics. */ > > =20 > > +extern bool sim_fpu_quiet_nan_inverted; >=20 > please avoid global variables. this should be part of sim_fpu state inst= ead. hrm, that doesn't work as sim_fpu is an operand ... i was thinking it was t= he FPU state. all the sim-fpu APIs today have been assuming stateless FPU whi= ch doesn't really work after this (and the other changes you're posting). please add a new sim_fpu_state structure that this would be a member of. t= hat can be a global variable for now, but leave a TODO comment about moving it = into the SIM_CPU structure. -mike --vTQ7TDy92zOavu51 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmHesSoACgkQQWM7n+g3 9YFeSg/+KQrrW5AgzHQ6oBVyHafOLNppUs6QGsMVJYx/Th9bRAjQccnj7xoJcPgk 7Buh4jyVc8syHwuT1n3XCZv/+8TneQOcVkup/v2T73SwtFSR9qJM7C0n7rDFHUi8 /VWiW5Ly24dKHuG8bfuAfppkkamNk8rHEroTkl/jjMJUiW0HhX2Shp9gSpPbtcdM Mdj4Krqdt3TLNl5Y54DaiYN8NXrMDwUn54BZEJV0ynzIlUtnsPLTNRtkpUgqK8sZ 0BAFXecIojqTwjvY8LhYKlEgdfAVnpo+8E5H6rlAtWMLXVUuwZlEecYBefCCcObo qUfY5zvn+sZkq94F24AgW7e9GNXoxQKkglgHI6KcaDw2VYMyoJRRvGCKtYGwjps/ cFvpmgLnbnoWVom5I/D2CR+j+QHwBdKCWTDYU9INgEoo8CrAxtsuLKGHg/PY6n+R 9+GjllUVwKZXC1RufkHNL7JTfVsLyW/MiT/eDlDwjfw9nVC05uKN9WFM8fqXM137 sja8cbjyejYEl7cN6PvuVlT9VTB5uBAjdZQJ1d4dKORmmUS+plyi+yIw1oFmQkyj oN9i84PUWFWvLPsEhGhHqKMlbTMCKWwV99pnxQvefMrc8RKCFmq6DRj/bAfWOJTK 447/IWqUuArModt7VqwYc38Qn37o7nREG45rzdM8POnX6sC8VYs= =qy8D -----END PGP SIGNATURE----- --vTQ7TDy92zOavu51--