From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org, Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH 0/2] Unify target announce and detach messages
Date: Sat, 8 Jan 2022 15:16:59 +0400 [thread overview]
Message-ID: <Ydlyq//B+TuWEU0E@adacore.com> (raw)
In-Reply-To: <20220105175916.2969966-1-tom@tromey.com>
Hi Tom,
On Wed, Jan 05, 2022 at 10:59:14AM -0700, Tom Tromey wrote:
> While slogging through all the printf's in gdb, I found some repeated
> code in the target layers to announce attach or detaches.
>
> This series unifies this code and removes the redundancies.
>
> I wasn't able to build some of these, as I don't have the proper
> operating systems. So, those are on a "best effort" basis.
Thanks for those patches. These are a nice little refactoring.
I agree with John that these look good.
--
Joel
prev parent reply other threads:[~2022-01-08 11:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 17:59 Tom Tromey
2022-01-05 17:59 ` [PATCH 1/2] Introduce target_announce_attach Tom Tromey
2022-01-08 15:07 ` Lancelot SIX
2022-01-08 16:47 ` Tom Tromey
2022-01-05 17:59 ` [PATCH 2/2] Use target_announce_detach in more targets Tom Tromey
2022-01-05 18:47 ` [PATCH 0/2] Unify target announce and detach messages John Baldwin
2022-01-08 11:16 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ydlyq//B+TuWEU0E@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).