public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>,
	Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH] gdbsupport: regenerate Makefile.in
Date: Sun, 16 Jan 2022 13:53:26 +0400	[thread overview]
Message-ID: <YePrFhhwtsChS/vj@adacore.com> (raw)
In-Reply-To: <d28b4948-a334-553f-fec7-bb995fe84189@polymtl.ca>

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

> Looks obvious to me, indeed the copyright update tool seems to get this
> wrong.  Either the tool should have a special case (which seems difficult),
> or the end-of-year procedure could include "re-generate the Makefiles" at
> the end, that would automatically revert these wrong automated changes.

The script has an EXCLUDE_LIST for situation like these. I've pushed
the attached patch to master.

-- 
Joel

[-- Attachment #2: 0001-gdb-copyright.py-Do-not-update-gdbsupport-Makefile.i.patch --]
[-- Type: text/x-diff, Size: 779 bytes --]

From a3f34021316d60ce33d2d52db76b463282519aef Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Sun, 16 Jan 2022 13:50:38 +0400
Subject: [PATCH] gdb/copyright.py: Do not update gdbsupport/Makefile.in

This file is generated, so we should not modify it (any modification
we make is going to be undone at the next re-generation anyway).
---
 gdb/copyright.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gdb/copyright.py b/gdb/copyright.py
index 3c44ae2d689..8ae9ffff65b 100644
--- a/gdb/copyright.py
+++ b/gdb/copyright.py
@@ -209,6 +209,7 @@ def main():
 EXCLUDE_LIST = (
     "gdb/nat/glibc_thread_db.h",
     "gdb/CONTRIBUTE",
+    "gdbsupport/Makefile.in",
     "gnulib/import",
     "gnulib/config.in",
     "gnulib/Makefile.in",
-- 
2.32.0


      reply	other threads:[~2022-01-16  9:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-10 17:46 Andrew Burgess
2022-01-10 17:52 ` Simon Marchi
2022-01-16  9:53   ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YePrFhhwtsChS/vj@adacore.com \
    --to=brobecker@adacore.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).