[PATCH] gdbsupport: regenerate Makefile.in

[PATCH] gdbsupport: regenerate Makefile.in

[Andrew Burgess]

I had cause to regenerate gdbsupport/Makefile.in, and noticed some
unexpected changes in the copyright header dates.

I suspect that this was caused by the end of year date range update
process.

The Makefile.in contains two date ranges.  The first range appears to
be the date range for the version of automake being used, that is the
range runs up to 2017 only, when automake 1.15.1 was released.

The second date range in Makefile.in represents the date range for the
generated file, and so, now runs up to 2022.

Anyway, this is the result of running autoreconf (using automake
1.15.1) in the gdbsupport directory.
---
 gdbsupport/Makefile.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdbsupport/Makefile.in b/gdbsupport/Makefile.in
index c93c9d964b5..36c2e3ddd95 100644
--- a/gdbsupport/Makefile.in
+++ b/gdbsupport/Makefile.in
@@ -1,7 +1,7 @@
 # Makefile.in generated by automake 1.15.1 from Makefile.am.
 # @configure_input@
 
-# Copyright (C) 1994-2022 Free Software Foundation, Inc.
+# Copyright (C) 1994-2017 Free Software Foundation, Inc.
 
 # This Makefile.in is free software; the Free Software Foundation
 # gives unlimited permission to copy and/or distribute it,
@@ -15,7 +15,7 @@
 @SET_MAKE@
 
 #
-#   Copyright (C) 2020-2021 Free Software Foundation, Inc.
+#   Copyright (C) 2020-2022 Free Software Foundation, Inc.
 #
 # This file is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
-- 
2.25.4

Re: [PATCH] gdbsupport: regenerate Makefile.in

[Simon Marchi]

On 2022-01-10 12:46, Andrew Burgess via Gdb-patches wrote:
> I had cause to regenerate gdbsupport/Makefile.in, and noticed some
> unexpected changes in the copyright header dates.
> 
> I suspect that this was caused by the end of year date range update
> process.
> 
> The Makefile.in contains two date ranges.  The first range appears to
> be the date range for the version of automake being used, that is the
> range runs up to 2017 only, when automake 1.15.1 was released.
> 
> The second date range in Makefile.in represents the date range for the
> generated file, and so, now runs up to 2022.
> 
> Anyway, this is the result of running autoreconf (using automake
> 1.15.1) in the gdbsupport directory.

Looks obvious to me, indeed the copyright update tool seems to get this
wrong.  Either the tool should have a special case (which seems difficult),
or the end-of-year procedure could include "re-generate the Makefiles" at
the end, that would automatically revert these wrong automated changes.

Simon

Re: [PATCH] gdbsupport: regenerate Makefile.in

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

> Looks obvious to me, indeed the copyright update tool seems to get this
> wrong.  Either the tool should have a special case (which seems difficult),
> or the end-of-year procedure could include "re-generate the Makefiles" at
> the end, that would automatically revert these wrong automated changes.

The script has an EXCLUDE_LIST for situation like these. I've pushed
the attached patch to master.

-- 
Joel

[-- Attachment #2: 0001-gdb-copyright.py-Do-not-update-gdbsupport-Makefile.i.patch --]
[-- Type: text/x-diff, Size: 779 bytes --]

From a3f34021316d60ce33d2d52db76b463282519aef Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Sun, 16 Jan 2022 13:50:38 +0400
Subject: [PATCH] gdb/copyright.py: Do not update gdbsupport/Makefile.in

This file is generated, so we should not modify it (any modification
we make is going to be undone at the next re-generation anyway).
---
 gdb/copyright.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gdb/copyright.py b/gdb/copyright.py
index 3c44ae2d689..8ae9ffff65b 100644
--- a/gdb/copyright.py
+++ b/gdb/copyright.py
@@ -209,6 +209,7 @@ def main():
 EXCLUDE_LIST = (
     "gdb/nat/glibc_thread_db.h",
     "gdb/CONTRIBUTE",
+    "gdbsupport/Makefile.in",
     "gnulib/import",
     "gnulib/config.in",
     "gnulib/Makefile.in",
-- 
2.32.0