From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id 51DC73858D35 for ; Sun, 16 Jan 2022 09:53:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 51DC73858D35 Received: by mail-wm1-x32c.google.com with SMTP id d18-20020a05600c251200b0034974323cfaso16869076wma.4 for ; Sun, 16 Jan 2022 01:53:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4EjIYgf1cK9c9yHa+DQxtBHnQgK0TL8MTOJd2F/nkJk=; b=35i95rrhTgC+DV1efcXqyJvKTuCQEMRT+VZC2NMn2Z0dbfbPvTWmTq4dV8dkwArhY9 udoCX0+3+1CEJrpsG+4wpCjrqPozMGG81/JqMcfLHWMv43rZ5FKqIPOLsHXbmmWe5s/0 IM/JlaUJ6xftDXezj3HDwpaQjaizLozHwL98nrpmJC9NIHhnltJ5kqovRiGGCKrDfgMK +q8oIFndlbFbRIiWQSRHRmqW3zICWkpVQ1kRw5AuToIYWixGeuULk1Mh1keUq2yB52b7 7vvU/YUSfgg58GJZKOdtme6M9iWVp+dtwTT9kRehayLrouXMdITc2mjqLmGi6XaOJoyB z6MA== X-Gm-Message-State: AOAM531Z69uFrRjGITTdV41vMjmyznLymhDaQGQFaC8FVLOH5XZ/uihz +KnrJ215Cyj9n/BYbl5aHpXnifSdbOg0 X-Google-Smtp-Source: ABdhPJw4a9BendGzr4lAFnLf9wAaG+wt2KU3B7MPKwpSAviKbEPpOpgezpEHLwJ7nUU8RIE9oEFUTQ== X-Received: by 2002:a1c:7209:: with SMTP id n9mr4372159wmc.83.1642326809731; Sun, 16 Jan 2022 01:53:29 -0800 (PST) Received: from takamaka.home ([2a01:cb22:1d5:1100:81b7:77bd:9588:f82b]) by smtp.gmail.com with ESMTPSA id c11sm17823768wmq.48.2022.01.16.01.53.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Jan 2022 01:53:28 -0800 (PST) Received: by takamaka.home (Postfix, from userid 1000) id 56ACAA84C2; Sun, 16 Jan 2022 13:53:26 +0400 (+04) Date: Sun, 16 Jan 2022 13:53:26 +0400 From: Joel Brobecker To: Simon Marchi via Gdb-patches Cc: Andrew Burgess , Joel Brobecker Subject: Re: [PATCH] gdbsupport: regenerate Makefile.in Message-ID: References: <20220110174634.890984-1-aburgess@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="EHkrT20aWea7zsXr" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jan 2022 09:53:33 -0000 --EHkrT20aWea7zsXr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > Looks obvious to me, indeed the copyright update tool seems to get this > wrong. Either the tool should have a special case (which seems difficult), > or the end-of-year procedure could include "re-generate the Makefiles" at > the end, that would automatically revert these wrong automated changes. The script has an EXCLUDE_LIST for situation like these. I've pushed the attached patch to master. -- Joel --EHkrT20aWea7zsXr Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-gdb-copyright.py-Do-not-update-gdbsupport-Makefile.i.patch" >From a3f34021316d60ce33d2d52db76b463282519aef Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Sun, 16 Jan 2022 13:50:38 +0400 Subject: [PATCH] gdb/copyright.py: Do not update gdbsupport/Makefile.in This file is generated, so we should not modify it (any modification we make is going to be undone at the next re-generation anyway). --- gdb/copyright.py | 1 + 1 file changed, 1 insertion(+) diff --git a/gdb/copyright.py b/gdb/copyright.py index 3c44ae2d689..8ae9ffff65b 100644 --- a/gdb/copyright.py +++ b/gdb/copyright.py @@ -209,6 +209,7 @@ def main(): EXCLUDE_LIST = ( "gdb/nat/glibc_thread_db.h", "gdb/CONTRIBUTE", + "gdbsupport/Makefile.in", "gnulib/import", "gnulib/config.in", "gnulib/Makefile.in", -- 2.32.0 --EHkrT20aWea7zsXr--