From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id 76EEC3858D3C for ; Sun, 6 Feb 2022 15:23:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 76EEC3858D3C Received: by mail-wr1-x42f.google.com with SMTP id f17so20667711wrx.1 for ; Sun, 06 Feb 2022 07:23:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OqrGHQ7STxOwVyIxQVw0S8UZDtm3OLVnqOo2r3+Qr3E=; b=swLqxbWaxVGQ5VcueKlcVdRx1NDrjc0+rMiK+M69bHULLqGeChC8P+GannulVr5QWs WqNdYw9Mk/SMylCD7N7CLfnUbuDQf7ilj/dRspcRaxq0rn3BRNBGWjeXNdpuBakK7jxQ 6q+XpL0hz9jj8hLTdfwim6QRqAivHg8sFMUwn10RQzIPk7ssD5NdViCfqTBv9WAS7IPV p3Cofxr0573d3TMYqYSUNNR77KwAfkZ+PQ288Y1megUMEUtWJPGG1lhZS4aW+EwkLUYz RwiCQha8SAf+3H9l0ALv80xzaEt89PvDiJBaB9T/L8M8j0H44X26AZ225x/i6sZVKvQ4 5/Sg== X-Gm-Message-State: AOAM533rHeLzkSVKz+L1jM6g7/Cj1okQ5rN4nTxmYfZrjXeJpC7ROmzl 3hTRU3IxE0cZVdR656ew151Rl5FW5PW5WOA= X-Google-Smtp-Source: ABdhPJzZ6Q0jMn112xbyOZ33bD5Mi22SwynmQIJRz5HuYQhGkFV7CeS6k1cOIqxqdy6ll3odYHUSSg== X-Received: by 2002:a05:6000:1a8e:: with SMTP id f14mr6810001wry.558.1644160982649; Sun, 06 Feb 2022 07:23:02 -0800 (PST) Received: from takamaka.home ([165.169.246.70]) by smtp.gmail.com with ESMTPSA id q13sm7522403wrd.78.2022.02.06.07.23.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Feb 2022 07:23:01 -0800 (PST) Received: by takamaka.home (Postfix, from userid 1000) id E6F6AA160D; Sun, 6 Feb 2022 19:22:55 +0400 (+04) Date: Sun, 6 Feb 2022 16:22:55 +0100 From: Joel Brobecker To: Simon Marchi via Gdb-patches Cc: Joel Brobecker Subject: Re: [PATCH 00/33] Remove some more accessor macros Message-ID: References: <20220128124531.2302941-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220128124531.2302941-1-simon.marchi@polymtl.ca> X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Feb 2022 15:23:05 -0000 Hi Simon, On Fri, Jan 28, 2022 at 07:44:58AM -0500, Simon Marchi via Gdb-patches wrote: > Most of this is mechanical, so probably doesn't need too much review. > But there are some changes near the beginning that move compunit > functions and methods, that's probably worth looking at. > > Simon Marchi (33): > gdb: add getter/setter for compunit_symtab::objfile > gdb: remove COMPUNIT_OBJFILE macro > gdb: rename compunit_primary_filetab to > compunit_symtab::primary_filetab > gdb: add compunit_symtab::add_filetab method > gdb: add compunit_symtab::set_primary_filetab method > gdb: move compunit_filetabs to compunit_symtab::filetabs > gdb: remove COMPUNIT_FILETABS macro > gdb: remove COMPUNIT_DEBUGFORMAT macro, add getter/setter > gdb: remove COMPUNIT_PRODUCER macro, add getter/setter > gdb: remove COMPUNIT_DIRNAME macro, add getter/setter > gdb: remove COMPUNIT_BLOCKVECTOR macro, add getter/setter > gdb: remove COMPUNIT_BLOCK_LINE_SECTION macro, add getter/setter > gdb: remove COMPUNIT_LOCATIONS_VALID macro, add getter/setter > gdb: remove COMPUNIT_EPILOGUE_UNWIND_VALID macro, add getter/setter > gdb: remove COMPUNIT_MACRO_TABLE macro, add getter/setter > gdb: remove SYMTAB_COMPUNIT macro, add getter/setter > gdb: remove SYMTAB_LINETABLE macro, add getter/setter > gdb: remove SYMTAB_LANGUAGE macro, add getter/setter > gdb: remove SYMTAB_BLOCKVECTOR macro > gdb: remove SYMTAB_OBJFILE macro > gdb: remove SYMTAB_PSPACE macro > gdb: remove SYMTAB_DIRNAME macro > gdb: remove SYMBOL_MATCHES_SEARCH_NAME > gdb: remove SYMBOL_ACLASS_INDEX macro, add getter/setter > gdb: remove SYMBOL_IMPL macro, add method > gdb: remove SYMBOL_CLASS macro, add getter > gdb: remove SYMBOL_DOMAIN macro > gdb: remove SYMBOL_OBJFILE_OWNED macro > gdb: remove SYMBOL_IS_ARGUMENT macro > gdb: remove SYMBOL_INLINED macro > gdb: remote SYMBOL_IS_CPLUS_TEMPLATE_FUNCTION macro > gdb: remove SYMBOL_TYPE macro > gdb: remove SYMBOL_LINE macro Thanks for this patch series. I reviewed the compunit series untit you started adding the getter/setter or eliminating the macros. After that, I only scanned the patches (burp, 'scuse me!). FWIW, those patches looked good to me. -- Joel