From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (dev.gentoo.org
 [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
 by sourceware.org (Postfix) with ESMTP id 119293857C45
 for <gdb-patches@sourceware.org>; Wed,  2 Feb 2022 03:39:21 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 119293857C45
Received: by smtp.gentoo.org (Postfix, from userid 559)
 id 8BB55343151; Wed,  2 Feb 2022 03:39:20 +0000 (UTC)
Date: Tue, 1 Feb 2022 22:39:19 -0500
From: Mike Frysinger <vapier@gentoo.org>
To: Dragan Mladjenovic <Dragan.Mladjenovic@syrmia.com>
Cc: gdb-patches@sourceware.org, "Maciej W . Rozycki" <macro@orcam.me.uk>,
 Chao-ying Fu <cfu@wavecomp.com>,
 Faraz Shahbazker <fshahbazker@wavecomp.com>
Subject: Re: [PATCH v4 1/4] sim: Allow toggling of quiet NaN-bit semantics
Message-ID: <Yfn85xk5AUZpkDFI@vapier>
Mail-Followup-To: Dragan Mladjenovic <Dragan.Mladjenovic@syrmia.com>,
 gdb-patches@sourceware.org,
 "Maciej W . Rozycki" <macro@orcam.me.uk>,
 Chao-ying Fu <cfu@wavecomp.com>,
 Faraz Shahbazker <fshahbazker@wavecomp.com>
References: <20220201125302.30137-1-Dragan.Mladjenovic@syrmia.com>
 <20220201125302.30137-2-Dragan.Mladjenovic@syrmia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="Q0UfvEw78SxBFXAq"
Content-Disposition: inline
In-Reply-To: <20220201125302.30137-2-Dragan.Mladjenovic@syrmia.com>
X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Feb 2022 03:39:22 -0000


--Q0UfvEw78SxBFXAq
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline

On 01 Feb 2022 13:52, Dragan Mladjenovic wrote:
> +sim_fpu_state _sim_fpu = { /* quiet_nan_inverted */ false };

we require C11, so you can use designated initializers.
sim_fpu_state _sim_fpu = {
  .quiet_nan_inverted = false,
};

> +/* State used by the FPU.
> +
> +   FIXME: This state is global, but should be moved to SIM_CPU .  */

no space before the .
-mike

--Q0UfvEw78SxBFXAq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmH5/OcACgkQQWM7n+g3
9YG8DQ//fPo9xgEnOdGDyZWNo0AR6LIneSj/BMDSxjrZPP+tbkipOpaJwwMqLBhV
SEk290/vm14SvDv/OORb3ciR6WJUc8HFwdaxlFHwKCmAi+zBGp2suL51uk/Gx/QH
tQXiBBzdqPyu+2YSvhMfgY8kDcKNvxHYCKerrz0YtAerz/wu4UvqT1JbFbOlUOlO
1j5aN+O6SSmIZ9wmoFPzRyALB6drp1pz5tB3dhMWJPZl9/OjxiTk0yn9sxGvx58C
Zcw0dHpAcz4ntU5G0cSK//AFCIxXd/g0JAdFirdYC4RwhyE3Bt1j4kbejBENWHFU
DviFV0cOex1jVNUyKFHJfhBfLGfrGCoZcdaopBajjvW4OHFJVEfs+Nt9B6HULofu
pa0i67nVmgoeT8RVPhDMvlXjQ5qecsWC/uFptvpiHAzAPqyaYA0kqOjtpSaN4FxA
QEVZ40TaXvgb23mmW/pF7mSYsZbwiaK8GGR7SfsLC4yhZyhYWj9t8YdCjvyIeaqg
oXB/7AjnQb74L9X3lTGva4Hjrla519bdYS+Mga8LKPWZNL3BO58LqMloesEYv9p8
HwDkOPF0U5G9tO6pVsu1oRRg+O8OZKAmAuuv5sBUuBv8l0KTUlFon8DsJb/k9Tcp
hZLJ/ObZm6f4H4I0JndlY8gs4It667MPqjnGkaxtAHurb7/vI70=
=/fuk
-----END PGP SIGNATURE-----

--Q0UfvEw78SxBFXAq--