From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (woodpecker.gentoo.org
 [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
 by sourceware.org (Postfix) with ESMTP id AFCB83858039
 for <gdb-patches@sourceware.org>; Wed,  2 Feb 2022 03:42:07 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AFCB83858039
Received: by smtp.gentoo.org (Postfix, from userid 559)
 id 26526343227; Wed,  2 Feb 2022 03:42:06 +0000 (UTC)
Date: Tue, 1 Feb 2022 22:42:05 -0500
From: Mike Frysinger <vapier@gentoo.org>
To: Dragan Mladjenovic <Dragan.Mladjenovic@syrmia.com>
Cc: gdb-patches@sourceware.org, "Maciej W . Rozycki" <macro@orcam.me.uk>,
 Chao-ying Fu <cfu@wavecomp.com>,
 Faraz Shahbazker <fshahbazker@wavecomp.com>
Subject: Re: [PATCH v4 3/4] sim: Add partial support for IEEE 754-2008
Message-ID: <Yfn9jVmbFx4d8B05@vapier>
Mail-Followup-To: Dragan Mladjenovic <Dragan.Mladjenovic@syrmia.com>,
 gdb-patches@sourceware.org,
 "Maciej W . Rozycki" <macro@orcam.me.uk>,
 Chao-ying Fu <cfu@wavecomp.com>,
 Faraz Shahbazker <fshahbazker@wavecomp.com>
References: <20220201125302.30137-1-Dragan.Mladjenovic@syrmia.com>
 <20220201125302.30137-4-Dragan.Mladjenovic@syrmia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="KezE2ftDbd7MU2lI"
Content-Disposition: inline
In-Reply-To: <20220201125302.30137-4-Dragan.Mladjenovic@syrmia.com>
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_NUMSUBJECT, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Feb 2022 03:42:08 -0000


--KezE2ftDbd7MU2lI
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline

On 01 Feb 2022 13:53, Dragan Mladjenovic wrote:
> +      /* In IEEE754-2008:
> +       * "minNum/maxNum is ... the canonicalized number if one
> +       * operand is a number and the other a quiet NaN." */

GNU style doesn't put * at the start of the wrapped line, and uses two
spaces before the closing */

> +/* Unordered/ordered comparison operators */

period at end

> +/* Changes the behaviour of the library to IEEE754-2008 or IEEE754-1985.
> + * The default for the library is IEEE754-1985. */

no leading * on wrapped lines and 2 spaces before */
-mike

--KezE2ftDbd7MU2lI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmH5/Y0ACgkQQWM7n+g3
9YGlBQ//RhokLhhnF3JBLA4hOjZ0+ss6pQ6BA527QBKR26nQI9tnaKmUvfw64wDP
nPSsrsvrKwfiWC5iTDvDkkx42iwQ/Y30j1el2RaLwG5q4nLgsDK0PO3GRI1f/dH8
CfZV9p8e2aaH/iIn6y+sfPsavQqHuav4sZNp4RZn+ozTeIm60DuDAbAFnfA3XNEL
0iZHNddBvjz0Sd5pifrUjq2XQ9mlRP+IOEKsCblYuBAp7HCPlfuMcuYQeDkPdWMp
PDqA6f25cCzDx/uNvAM1LPmK/3VFJ+ievO0FmdbGrxO6mpfoqSODqGSO2dG/j64l
M4Do2kJya7NqpT3p3rN5DBL6TWn6UALdjP1XJNnXQ1BwAjC8VbkWseNoxWJMb6RV
8+agwSq+NFmcIDA42K1ia1lPjcME2YxB4KJ6ZRRT94+5BHT8mLSYN+rUqHewB1UV
SBJvS8Hb9q270voAs7Ft1yLisBffzV0KLueTgm+dXbPJTE1h3ELu/5XKw9bgfm0F
KGzevVM5rhwKfe7Je+OYE7rfvihAPovh17CbjD7AlU8fTFVFLOow/JTc+QwH6kAl
nrrtRidvdCuJF7FjVUnWS3CyLq+ErJrXgwe19rugEdwKXCv49sYOK6Ch20j3EOpv
hXaumFW2evY9u8WyXFjaxM8ZX6Npjwq7H8jkzi4Nb6vkWLQ/UkY=
=0Obo
-----END PGP SIGNATURE-----

--KezE2ftDbd7MU2lI--