From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 91E0D3858D20 for ; Thu, 17 Feb 2022 05:30:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 91E0D3858D20 Received: by smtp.gentoo.org (Postfix, from userid 559) id 8E42D34313A; Thu, 17 Feb 2022 05:30:42 +0000 (UTC) Date: Thu, 17 Feb 2022 00:30:40 -0500 From: Mike Frysinger To: Hans-Peter Nilsson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 10/12] sim: Add sim_dump_memory for debugging Message-ID: Mail-Followup-To: Hans-Peter Nilsson , gdb-patches@sourceware.org References: <20220214225824.AC90A20439@pchp3.se.axis.com> <20220214230631.BA3A320439@pchp3.se.axis.com> <20220217020545.1A52420434@pchp3.se.axis.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HZi5l4PLuxRg/H6L" Content-Disposition: inline In-Reply-To: <20220217020545.1A52420434@pchp3.se.axis.com> X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Feb 2022 05:30:45 -0000 --HZi5l4PLuxRg/H6L Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 17 Feb 2022 03:05, Hans-Peter Nilsson wrote: > > On 15 Feb 2022 00:06, Hans-Peter Nilsson via Gdb-patches wrote: > > > --- a/sim/common/sim-memopt.c > > > +++ b/sim/common/sim-memopt.c > > > > > > +/* Convenience function for use when debugging the simulator. */ > >=20 > > can you clarify that it's meant for an attached debugger to call vs a > > manual call from within the sim itself ? i know your commit message > > said that, but the code comment would help too. > >=20 > > i vaguely recall seeing another such hook point in the > > tree. >=20 > That *could* have been in gdbinit.in a.k.a. .gdbinit. hrm, maybe. i want to say it was real code. maybe in one of the ports. at any rate, prob not worth diving deeper for now. > Speaking of that, I just noticed there's no .gdbinit in > sim/ anymore. They aren't build from sim/common/gdbinit.in > apparently due to some mixup of @SIM_COMMON_BUILD_FALSE@ and/or > @SIM_COMMON_BUILD_TRUE@ which seems to have been introduced in > your 36bb57e40c506. (No, not planning on going there.) thanks for pointing this out. it was left behind because it has a configure dependency on cgen ports and i hadn't figured out how to unwind that. but =66rom playing around a bit, i think we can just always set the breakpoint. if the symbol doesn't exist, gdb will warn, but that's it. if you know how to get it to not complain, i'm all ears. -mike --HZi5l4PLuxRg/H6L Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmIN3YAACgkQQWM7n+g3 9YF7TRAAkdTGMY7aGTg8CfT5h8aFk7vUZOZ2UDGPyURkqaN1TYTJUVpUawIO5VDv k4Koc2WJsrQ+W4yg+rY+rngsjUhudMiKYT6dJ0wGmSTYNpi3uT5dqIKCqPRU5zzO 4r5VogN8cQWpvjGrWzpzo96gK83i6cOTk/j2vb098AgHgYZa8otxW/IEdGZ92Gph RZ7wTWIoeY3yRffDvWa8W3js/Lc1d+YUloPI7a0W43reXt8mDEIeriR/gXaHqW6L ThUapN/LThJa8laWqvnSt7EwEYDfBz2I70yDm3C6kLldlAHAG3deG3sI4yuOc3Gs V6TBbw17yEE9s/DFcrmHncWde5WpU3SIaQayOctN3YnrY+uZNe1E4ENfzQbMbhXO lZPP4nNG23PURUYu56ohKS5IHdO9UYqHJW+XW55huS3Yr+3jcD2p8ViGSNmrV+hV YW/fx9wLUJ0n9RWjIqoI1SDW20iRQBfya7q8QqZ1zO40I8onGBwSpQbtbiHMaj0o T9RiWP8IYn8ZWVtakPx79AnCC4RArZw/g198+jCUsuK9Bw0J6XrtePkSXkdm2rT8 lO2qlLVNMR7dGvL5wvr00m34lkXvQGVC07wWw1FzB0x2/k07OZLHeuMy0Nf/2FGb 3BBZWDvxUMn4zR1WqCfnyCeofeRoodRKc6hY0knS0oHXXrPY0jc= =S+rX -----END PGP SIGNATURE----- --HZi5l4PLuxRg/H6L--