From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id D063B3858D3C for ; Wed, 16 Feb 2022 04:49:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D063B3858D3C Received: by smtp.gentoo.org (Postfix, from userid 559) id DC68C3432CF; Wed, 16 Feb 2022 04:49:49 +0000 (UTC) Date: Tue, 15 Feb 2022 23:49:47 -0500 From: Mike Frysinger To: Hans-Peter Nilsson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 06/12] sim/testsuite: Support "requires: simoption <--name-of-option>" Message-ID: Mail-Followup-To: Hans-Peter Nilsson , gdb-patches@sourceware.org References: <20220214225824.AC90A20439@pchp3.se.axis.com> <20220214230356.BA97820439@pchp3.se.axis.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BCU5DrZAvGY3Psp3" Content-Disposition: inline In-Reply-To: <20220214230356.BA97820439@pchp3.se.axis.com> X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Feb 2022 04:49:52 -0000 --BCU5DrZAvGY3Psp3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 15 Feb 2022 00:03, Hans-Peter Nilsson via Gdb-patches wrote: > Simulator features can be present or not, typically > depending on different-valued configure options, like > --enable-sim-hardware[=3Doff|=3Don]. To avoid failures in > test-suite-runs when testing such configurations, a new > predicate is needed, as neither "target", "progos" nor > "mach" fits cleanly. >=20 > The immediate need was to check for presence of a simulator > option, but rather than a specialized "requires-simoption:" > predicate I thought I'd handle the general (parametrized) > need, so here's a generic predicate machinery and a (first) > predicate to use together with it; checking whether a > particular option is supported, by looking at "run --help" > output. This was inspired by the check_effective_target_ > machinery in the gcc test-suite. i really don't want --help to be an API surface like this. it's the wrong layer for the job. we have a sim_config_print function which dumps configuration information. i'd be fine making that the surface to build off of. i don't think we print hardware there atm, but should be trivial to introduce. only other missing piece is that it's not obvious how to access it from the CLI. `run --version` doesn't include it. `run --do-command version` does though :x. i'd be amenable to improving this interface, either by a new option like --info-config or some other route. -mike --BCU5DrZAvGY3Psp3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmIMgmsACgkQQWM7n+g3 9YGXOw//VxJedLegjyfR3cs4Y7iv8H2Szk7zKQQICOVe5zzhGgsVlZa75K9/oKfz X+2cnVjjivacbL4+fyjMvDDGmBI0w61KN9n+xMLYqhOBc8t1bwLBd7SifRUbwklv R6QRNxJf5obyVQHHoAGG5C5TtwpVleqQW0oTNyHYHgXRDYPa3g3LQvVESKEzFMm6 vTxQ1xTfh5vl2WNLD4I3jVGW4UIB3ZIU9quvqRU97Z3B8o+pHQBhWkh19QE26ntS Nf+v+8Q+utD/VGG2eOHBkXV7vvPdmoNtLmrTDdcYLOAJzcFjRo461d3LIjlQ802O i1EnsY+8WAOxqPSFzlkwNsHg77b8zQG48kmYkaPCa+yuHvQQ8jPu4yL244uTLFtc ML3MrKcxDYe0emC2HTHGH44ulJmgVbv1JWOiG6tF7ZpAxZeUEptowAUi3OmwZg61 sk40WD9UK9GSLB1CSfQilNGhavtL22PxxHedfKss5SwI/qWjkZH64/p/n9N1FyhJ 6gxUbFaiO4i7p0h10o345z8Hs611d1vMfdc6/xWJx+S7kr/jVgZhP3i2HvHFf6tQ ZLlg+nsaSLZpA6Y1uJysJFrENNhEDJ3vlbS0xVXfVVnJsokAvIglSC3P4l1QJqnV By6DmVamZkM0Q1ObF9JvUMbCL2DC7PA9+v13X8PqWSRCpNoIDUo= =B2Bs -----END PGP SIGNATURE----- --BCU5DrZAvGY3Psp3--