From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vapier@gentoo.org>
Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183])
 by sourceware.org (Postfix) with ESMTP id 83DC33858D3C
 for <gdb-patches@sourceware.org>; Wed, 16 Feb 2022 04:51:18 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 83DC33858D3C
Received: by smtp.gentoo.org (Postfix, from userid 559)
 id 237503432CC; Wed, 16 Feb 2022 04:51:18 +0000 (UTC)
Date: Tue, 15 Feb 2022 23:51:16 -0500
From: Mike Frysinger <vapier@gentoo.org>
To: Hans-Peter Nilsson <hp@axis.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 08/12] sim cris: Unbreak --disable-sim-hardware builds
Message-ID: <YgyCxJknleV9ruEz@vapier>
Mail-Followup-To: Hans-Peter Nilsson <hp@axis.com>, gdb-patches@sourceware.org
References: <20220214225824.AC90A20439@pchp3.se.axis.com>
 <20220214230512.7B80720439@pchp3.se.axis.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="OgpBKw6Ao5uC6pd/"
Content-Disposition: inline
In-Reply-To: <20220214230512.7B80720439@pchp3.se.axis.com>
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Feb 2022 04:51:19 -0000


--OgpBKw6Ao5uC6pd/
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline

On 15 Feb 2022 00:05, Hans-Peter Nilsson via Gdb-patches wrote:
> +#if WITH_HW
>    if (cris_have_900000xxif)
>      sim_hw_parse (sd, "/core/%s/reg %#x %i", "cris_900000xx", 0x90000000, 0x100);
> +#else
> +  /* With the option disabled, nothing should be able to set this variable.
> +     We should "use" it, though, and why not assert that it isn't set.  */
> +  ASSERT (! cris_have_900000xxif);
> +#endif

WITH_HW is always defined to either 1 or 0.  could you write:
  if (WITH_HW)
    ...
  else
    ...

this avoids bit rot in the uncommon configure paths
-mike

--OgpBKw6Ao5uC6pd/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmIMgsQACgkQQWM7n+g3
9YF4sA//R1LiLDP1SeOzb7zy2RrH+aaNO0O89AKxwTPnA8J8HpmNzl3fKDaRqYY4
rfsdrPyvPjNrPW4JFtbGl94Qpz0TshlBiF4V1uuglQFMTGfuCd4JH/1xeyYzs5Wu
IrDnj2ieW1cT6o8CXkLoAJ3at9le+cZPX529gDmJO7gLtT4d1KzA2hcLkF+eudoU
veCtxEOH7Nn/WDxan2epqves5ifdeC3mLsFKRYtmuYd6z1RPh0/VxPoQ1V6xh9F0
noVwyQk83Lv99a8TZ9ENC+sFgO8g4jIW+hV/RylGymsNPopD+0X0yb9U9JW/Z6Tx
HDlym5l8K8NVktIdSPhUAqPdj4zZ2Gx5iV6lIJzeg1xO/CHBTn4czgYx7bKRfBxI
mi8Li1Owe+tLVLIVlFBk914KJe0jELdp5MlMxxNUalL0/khw8NUAPdupdhff6fh+
w0Eu/OmDTWtmW8bDt+HvsdrsXKApOtEU/JbryC+KxfjoliE08sar81iJ2ix+jLaB
//HHnzV2zFVXYE0cWfFV82Dr4zdJBNqsv6gF1kjTjOdQuvpBZYuoPbUKuO8p4MW4
Wvo444Y5diYXwubN/0I8uovbjIYG26u5F7kuPifL52zIMq6kBTxLRWX/qk2kVZ7f
u0tNLIoV1MgRtSH99RVmxXHODeSiHLlCTFg/U2MGRHDrtufNiag=
=o/Ky
-----END PGP SIGNATURE-----

--OgpBKw6Ao5uC6pd/--