From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 837F53858D3C for ; Wed, 16 Feb 2022 05:25:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 837F53858D3C Received: by smtp.gentoo.org (Postfix, from userid 559) id 7EB36342BB0; Wed, 16 Feb 2022 05:25:09 +0000 (UTC) Date: Wed, 16 Feb 2022 00:25:07 -0500 From: Mike Frysinger To: Hans-Peter Nilsson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 04/12] sim/testsuite/cris/c: Use -sim3 but only for newlib targets Message-ID: Mail-Followup-To: Hans-Peter Nilsson , gdb-patches@sourceware.org References: <20220214225824.AC90A20439@pchp3.se.axis.com> <20220214230255.DC76120439@pchp3.se.axis.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6O+HYqFsxVdfLJwJ" Content-Disposition: inline In-Reply-To: <20220214230255.DC76120439@pchp3.se.axis.com> X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Feb 2022 05:25:12 -0000 --6O+HYqFsxVdfLJwJ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 15 Feb 2022 00:02, Hans-Peter Nilsson via Gdb-patches wrote: > Commit a39487c6685f "sim: cris: use -sim with C tests for cris-elf > targets" caused " -sim" to be appended to CFLAGS_FOR_TARGET for > cris*-*-elf, where testing had until then relied on > "RUNTESTFLAGS=3D--target_board=3Dcris-sim" being passed when running "make > check-sim", adding the right options. While "-sim" happens to work, > the baseboard-file cris-sim.exp uses "-sim3" so for consistency use > that instead. >=20 > Then commit b42f20d2ac72 "sim: testsuite: drop most specific istarget > checks" caused " -sim" to be appended for *all* targets, which just > doesn't work. For example, for crisv32-linux-gnu, that's not a > recognized option and will cause a dejagnu error and further testing > in c.exp will be aborted. >=20 > While cris-sim.exp appends "-static" for *-linux-gnu, further changes > in the test-suite have caused "linux"-specific tests to break, so that > part will be tended to separately. >=20 > But, save and restore CFLAGS_FOR_TARGET around the modification and > use where needed, to not have the CRIS-specific modification affect a > continuing test-run (possibly for other targets). i'm trying to get away from needing dejagnu boards at all. it brings nothi= ng to the table when it comes to testing the sim itself. ideally we should ha= ve a single sim binary that supports all targets simultaneously, and it's only runtime options (or dynamic probing) that selects between them. that's why #progos was introduced -- so tests could declare which env they're targeting and the test framework can run the simulator with the right settings. one can now do: $ ./configure --enable-targets=3Dall $ make check-sim and every architecture will be built & tested. no need for multiple build dirs for diff targets or sep runs with diff runtestflags. at some point i also want to delete all the custom compile+run logic in the testsuite/cris/ tree. that's why i spent so much time pulling code out and into the common one. i even have a poc locally that deletes the dejagnu framework entirely and switches to Automake test harness, but i haven't quite figured out how to cleanly handle the all_machs multiplex logic in Automake. i eventually pulled out individual cleanups and merged them so at least `make check` works in a multi-target build, and isn't nearly as slow as it was. -mike --6O+HYqFsxVdfLJwJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmIMirMACgkQQWM7n+g3 9YH8aRAAuG7y4meA5Jv2otdgUvkGttTDmjlAp+7AVenMjyRmdEuV/2ogGQtbieC6 JAwSIUGyJERI6I6L3ZcU3vSqQrj9rrUqF4Hxte1LqbI9j0Ay8NRCoEYK+cxA4z3z WO2BUHgxH7dWvnOFxgGMA4uDgA65v2c8pEmytGYEK/jRUIRvPKQsh+Pb0LJ6KgB+ qCEN1w/wdzAcw+p66GGS2sJ/USUnnSeiJg2GGXF0Fa/Nj65pqFHqBIY7NZEKKmtu 7ybe7CXpC8SwFdCxas+DPkk7TqnheduMrmevTF7kT+7bV3SURvSuggghCQwQXviD hnpjTKZ4ArduEwDufOHTo+tcNSlzexZu25AaSji6LZq2LuQEZhaMmKQMze8njX7v upgdd6f4k1Aait32JXcb5GlfO2xY1bFO6wj4F66lFcpt+a9c+oAlrzEL19l5u6Lx QfqX88ZE0QtfvFF6w0zmBcBfvgGZq1Fs7DV00VwWMOqoVotYnbHcO5/WitM5h/bz 08qMMMEiAG5/jKuwSmupdbcELaTHG0NPEmiLJuaoQQenmQwJh1/3jnb79ncqCsxH 2WgQLLq+HQ39LmnY8ezpiXPn3u2VUwVPPI0wAFaHlWb/48115DeO+QmBnZ3ZrgYQ Pn9QHneem/o2xrum0a2F0ybs/bY2EDGz3mLUKzbhEM7+1y3uryc= =kHjK -----END PGP SIGNATURE----- --6O+HYqFsxVdfLJwJ--