From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by sourceware.org (Postfix) with ESMTPS id 7AC3A3858D35 for ; Sun, 20 Feb 2022 11:39:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7AC3A3858D35 Received: by mail-wm1-x32a.google.com with SMTP id o34so7950594wms.1 for ; Sun, 20 Feb 2022 03:39:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dPONzzqmYn/Es3n+E8Q4Q20vy4MVfttobSieQswrpDg=; b=o/hrjXs3fxhbRk4LQxCX5fleWOC+x2cgDp1CJRK/3aGdw0FI3TkNPcFS2kNPG/d7A+ 9YUPE11zMJGtOW+QC+wkI81m9c9UfU0sFQluRQHXhYAjNyiq5j/zuATZUavUeiyT0oZU 1JTrezQEUu1cMF5mx+CdaEUXDavDhc2j+AnYPqj8IOC1wWwl72HH9SN/BwG3Vjql+8ML Y0I1/oyfD691lqyrCr13Si7gKNhbcAIMVXY8JKk8q3FiWzGjHl29NRtHpR68SHVkYlW5 DI33HsX7sEvlRnmZGV96AbQcweAMVybuQQ5DFaJ2fNkJVM96ukWyxuXikmaBxRcMmt+X nXqA== X-Gm-Message-State: AOAM530Sqs9rx6spEXJYDqOdyYxnO/6ri+bgMPCkwRUfUT9bjEUF5Hc7 Sikeo8EMJBi5go/90uBRDxfz X-Google-Smtp-Source: ABdhPJypzQCHzuWOIJ5EkYSzXVgvohV/0e+lOuesQKKa14RfDgh3Z+i/Z/zpyu7ST6b/CaK/6u6j2g== X-Received: by 2002:a05:600c:4782:b0:37b:f836:78c7 with SMTP id k2-20020a05600c478200b0037bf83678c7mr17274321wmo.129.1645357140009; Sun, 20 Feb 2022 03:39:00 -0800 (PST) Received: from takamaka.home ([2a01:cb22:1d5:1100:919b:6961:9809:fa31]) by smtp.gmail.com with ESMTPSA id t2sm28742645wrr.55.2022.02.20.03.38.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 03:38:59 -0800 (PST) Received: by takamaka.home (Postfix, from userid 1000) id 2539EA1610; Sun, 20 Feb 2022 15:38:57 +0400 (+04) Date: Sun, 20 Feb 2022 15:38:57 +0400 From: Joel Brobecker To: John Baldwin Cc: gdb-patches@sourceware.org, Joel Brobecker Subject: Re: [PATCH v5 07/15] inf-ptrace: Return an IGNORE event if waitpid() fails. Message-ID: References: <20220121201631.63530-1-jhb@FreeBSD.org> <20220121201631.63530-8-jhb@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220121201631.63530-8-jhb@FreeBSD.org> X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Feb 2022 11:39:03 -0000 Hi John, On Fri, Jan 21, 2022 at 12:16:23PM -0800, John Baldwin wrote: > Previously this returned a TARGET_WAITKIND_SIGNALLED event for > inferior_ptid. However, inferior_ptid is invalid during ::wait() > methods after the multi-target changes, so this was triggering an > assertion further up the stack. > --- > gdb/inf-ptrace.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/gdb/inf-ptrace.c b/gdb/inf-ptrace.c > index 6e4706a3d20..0b94aad54d7 100644 > --- a/gdb/inf-ptrace.c > +++ b/gdb/inf-ptrace.c > @@ -313,9 +313,8 @@ inf_ptrace_target::wait (ptid_t ptid, struct target_waitstatus *ourstatus, > _("Child process unexpectedly missing: %s.\n"), > safe_strerror (save_errno)); > > - /* Claim it exited with unknown signal. */ > - ourstatus->set_signalled (GDB_SIGNAL_UNKNOWN); > - return inferior_ptid; > + ourstatus->set_ignore (); > + return minus_one_ptid; > } > > /* Ignore terminated detached child processes. */ This patch looks good to me. -- Joel