From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id ABB813858D35 for ; Sun, 27 Feb 2022 11:35:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ABB813858D35 Received: by mail-wr1-x42c.google.com with SMTP id x15so11191535wrg.8 for ; Sun, 27 Feb 2022 03:35:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gRe7/v1ejGo4POLPVhyxiN1FJPPdHOlu5bWurXjpkP8=; b=iSHaoGv0OhmJITkVt/mXUNOpSVSUPeEFJxcUZ2AtLTILJQYBJLFHJmbRmm/ext6uTJ /8pspSPG+h+gPgjjALq8UMnuNoTd3fI+dm5nMNALkAVL/6CRQdWqUW1Yb0XrFsnVGB36 Wr/TsY/zWbr8+5LERSAK4fMs4mRYMAFjT0wy8jCZu4vEopPhACyo8353dvexbx1+OBxc WPaI/vJeiAaKf6tCs38GAtpXi9MJHvuPMO+5yT9mYh+OTWDNdRwZGQ+DcDfLpj+9pHwT YYVZSniKpqTAxnwxHg8DS8QpoY4mRByfM+YcRXNqjM897oBYwGSSxL9aIK8x0vB9A/JK V+sg== X-Gm-Message-State: AOAM5306n95zG5ViAePUWe0BbfGTIpC+iT277at1FDLe/la9vn59ktL7 FqZ+/erhPo67oOjL8hLCXFoo X-Google-Smtp-Source: ABdhPJw+rl01aOXRWu0oxccmGqDGPFkDQHIOF60UI++ycgdZB6/UENckkq4mCYvLK3EKDbmta/pEjg== X-Received: by 2002:adf:ea01:0:b0:1ea:8200:8ae5 with SMTP id q1-20020adfea01000000b001ea82008ae5mr12352902wrm.607.1645961745757; Sun, 27 Feb 2022 03:35:45 -0800 (PST) Received: from takamaka.home ([2a01:cb22:1d5:1100:1832:f2a9:60eb:478a]) by smtp.gmail.com with ESMTPSA id y7-20020adff147000000b001dbd1b9812fsm10762219wro.45.2022.02.27.03.35.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Feb 2022 03:35:45 -0800 (PST) Received: by takamaka.home (Postfix, from userid 1000) id 89395A49F4; Sun, 27 Feb 2022 15:35:41 +0400 (+04) Date: Sun, 27 Feb 2022 15:35:41 +0400 From: Joel Brobecker To: Maxim Kuvyrkov via Gdb-patches Cc: Luis Machado , torbjorn.svensson@st.com, Yvan Roux , Joel Brobecker Subject: Re: [PATCH v3 0/5] arm: Add support for multiple stacks on Cortex-M Message-ID: References: <20220204084151.14480-1-christophe.lyon@gmail.com> <45235B67-731E-4EE7-81E1-62A720E963A4@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45235B67-731E-4EE7-81E1-62A720E963A4@linaro.org> X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Feb 2022 11:35:48 -0000 > Will you be able to review this patch series from Christophe? I see that the v3 series was posted on Feb 4th, while on Feb 6th I reviewed v2 :-(. This is really unfortunate that we don't have a better system for tracking whether a version of a series is trully the latest version. Can you take a look at the comments and question I asked in v2, and publish a v4 which takes those into account? Please Cc: me on the submission of the patches, this will help me remember to prioritize those patches. > > Thank you, > > -- > Maxim Kuvyrkov > https://www.linaro.org > > > On 4 Feb 2022, at 11:41, Christophe Lyon via Gdb-patches wrote: > > > > From: Christophe Lyon > > > > This patch series introduces support for the multiple stack pointers > > on v8-M architecture (MSP_S, MSP_NS, PSP_S, PSP_NS). > > > > This enables to unwind through Secure vs Non-secure context switches. > > > > Along the way, the first patch adds support to detect vpush > > instructions in function prologues, which in particular is used in the > > CMSE trampolines. > > > > v3 fixes two small silly mistakes in patches 4 and 5. > > > > Christophe Lyon (5): > > gdb/arm: Fix prologue analysis to support vpush > > gdb/arm: Define MSP and PSP registers for M-Profile > > gdb/arm: Introduce arm_cache_init > > gdb/arm: Add support for multiple stack pointers on Cortex-M > > gdb/arm: Extend arm_m_addr_is_magic to support FNC_RETURN, add > > unwind-ns-to-s command > > > > gdb/NEWS | 5 + > > gdb/arch/arm.c | 6 + > > gdb/arch/arm.h | 1 + > > gdb/arm-tdep.c | 698 +++++++++++++++++++++++++----- > > gdb/arm-tdep.h | 10 + > > gdb/doc/gdb.texinfo | 10 + > > gdb/features/Makefile | 1 + > > gdb/features/arm/arm-m-system.c | 15 + > > gdb/features/arm/arm-m-system.xml | 12 + > > gdb/features/arm/arm-secext.c | 17 + > > gdb/features/arm/arm-secext.xml | 15 + > > 11 files changed, 691 insertions(+), 99 deletions(-) > > create mode 100644 gdb/features/arm/arm-m-system.c > > create mode 100644 gdb/features/arm/arm-m-system.xml > > create mode 100644 gdb/features/arm/arm-secext.c > > create mode 100644 gdb/features/arm/arm-secext.xml > > > > -- > > 2.25.1 > > > -- Joel