Re: [PATCH] Powerpc fix for gdb.base/ending-run.exp

[Joel Brobecker <brobecker@adacore.com>]

Hi Carl,

> diff --git a/gdb/testsuite/gdb.base/ending-run.exp b/gdb/testsuite/gdb.base/ending-run.exp
> index 32435b2b509..38a52b91e9c 100644
> --- a/gdb/testsuite/gdb.base/ending-run.exp
> +++ b/gdb/testsuite/gdb.base/ending-run.exp
> @@ -202,6 +202,13 @@ gdb_test_multiple "next" "step out of main" {
>  	# This is what happens on system using uClibc.
>  	pass "step out of main"
>      }
> +    -re ".*from /lib/powerpc.*$gdb_prompt $" {

I really think we should try to match the fact that we were unable
to determine the name of the function in the frame information.
Wouldn't otherwise the regexp above also match when your system
does have the debugging information, incorrectly leading us to
stop the testing when we should be able to continue?

> +	# This case occurs on Powerpc when gdb steps out of main and the
> +	# needed debug info files are not loaded on the system so gdb can
> +	# see it stepped to function into __libc_start_call_main.

"stepped to function into xxx" seems odd.

I'd like to also add an explanation as to why we set program_exited,
and in particular why the situation we just detected makes us unable
to continue the testing.

What about...

	# This case occurs on Powerpc when gdb steps out of main and the
	# needed debug info files are not loaded on the system, preventing
	# GDB to determine which function it reached (__libc_start_call_main).
        # Ideally, the target system would have the necessary debugging
        # information, but in its absence, GDB's behavior is as expected.
        #
        # Another consequence of this missing information is that GDB
        # can no longer continue to perform "next" operations, as doing
        # so requires GDB to know the bounds of the current function.
        # Not know what the current function it, it cannot determine
        # its bounds. So we also set program_exited to 1 to indicate
        # that we need to stop this testcase at this stage of the testing.

?
> +	pass "step out of main"
> +	set program_exited 1
> +    }
>  }
>  
>  # When we're talking to a program running on a real stand-alone board,
> -- 
> 2.32.0
> 
> 

-- 
Joel