From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id E84F83858009 for ; Sun, 20 Mar 2022 06:02:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E84F83858009 Received: by mail-wm1-x32e.google.com with SMTP id bi13-20020a05600c3d8d00b0038c2c33d8f3so6066868wmb.4 for ; Sat, 19 Mar 2022 23:02:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iaWWeVTaA7CQvcgrF+nMRnKIYQYJz2Xd+J4Cz21pnLs=; b=4n+ePY6eVt0yCBLY0Y/uQPlLWVtjmygluARDq6u2IAXDLrk6BMkt1+AM+LyWO2EUHZ jG+YIHRMmOvTqYdNQDmmJGUV3h9gTqr6GxtuY/6ESMp/4L8+Wt/t7DJVkjPqTRdLaceM 11cINjStd8SxUOI6DKPPgM2qqJuFfkJUBegiXANvzuwYHIbZ3wWUIwntUfCmt/2sYaXo 2/HkW1Qa0zgGrTFRONeiQGED8NLKNRDNs5UuKolMhaJwF/orHiF3YN8bHr6QL2J9RzvF 08BIUQ8DGWRZMOn/o+y0abVye3NkUN/0axvXwkKkKGr3JoUev0SfnzYkAYc7t8DoC5ry PUDA== X-Gm-Message-State: AOAM530x8VWfak4SqxvQqK3QisUSeVb/l7f5JQJMLSr4DQLA8jAU78CN mtrodqdC/m6YK6vYu7elWMLbAYGiCj/Q X-Google-Smtp-Source: ABdhPJzidfuRGom6CdsDGZ7Rea7Dn88+xPAbKy/KKLZbET7ffjORhFqGWkWKr0g7K2AGLvYJiOzlfg== X-Received: by 2002:a05:600c:35d4:b0:38c:9933:41c0 with SMTP id r20-20020a05600c35d400b0038c993341c0mr3883121wmq.149.1647756153798; Sat, 19 Mar 2022 23:02:33 -0700 (PDT) Received: from takamaka.home (lfbn-reu-1-503-119.w92-130.abo.wanadoo.fr. [92.130.90.119]) by smtp.gmail.com with ESMTPSA id u11-20020a05600c19cb00b00389efe9c512sm15371815wmq.23.2022.03.19.23.02.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Mar 2022 23:02:33 -0700 (PDT) Received: by takamaka.home (Postfix, from userid 1000) id 8FA57A4D6D; Sun, 20 Mar 2022 10:02:30 +0400 (+04) Date: Sun, 20 Mar 2022 10:02:30 +0400 From: Joel Brobecker To: Tom Tromey via Gdb-patches Cc: Tom Tromey , Joel Brobecker Subject: Re: [PATCH] Don't test interface.exp without GNAT debug info Message-ID: References: <20220317143905.1743262-1-tromey@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220317143905.1743262-1-tromey@adacore.com> X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Mar 2022 06:02:36 -0000 Hi Tom, On Thu, Mar 17, 2022 at 08:39:05AM -0600, Tom Tromey via Gdb-patches wrote: > The test gdb.ada/interface.exp requires some debug info in the GNAT > runtime. When run without this info, the test can't pass. This patch > changes the test to detect this situation and stop the test with > "untested". Thanks for the patch. It looks good to me. > --- > gdb/testsuite/gdb.ada/interface.exp | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/gdb/testsuite/gdb.ada/interface.exp b/gdb/testsuite/gdb.ada/interface.exp > index 834da12b153..06b9660113b 100644 > --- a/gdb/testsuite/gdb.ada/interface.exp > +++ b/gdb/testsuite/gdb.ada/interface.exp > @@ -17,6 +17,11 @@ load_lib "ada.exp" > > if { [skip_ada_tests] } { return -1 } > > +if {![gnat_runtime_has_debug_info]} { > + untested "GNAT runtime debuginfo required for this test" > + return -1 > +} > + > standard_ada_testfile foo > > if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug additional_flags=-gnat05 ]] != "" } { > -- > 2.34.1 > -- Joel