From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id 972223858C56 for ; Sun, 10 Apr 2022 19:06:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 972223858C56 Received: by mail-pf1-x434.google.com with SMTP id b15so12763573pfm.5 for ; Sun, 10 Apr 2022 12:06:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=178lw0CJ0ranTULR+HF3N3Thxo4EKFOxRrnJW1Ci+M8=; b=N3IkGXhub37do7O77OzPCPBE07vKDSINEhz6ETlE6am1KdRn2H357yKvJJ2/WItp3f FuX7WydaPRm4sbdTBhx0f3d995gFY1mL2J2PbColaPPADv1AP8UedIZNaxAwwlx6LBdq Y1XAAIU6gZxs5O89AkDv45EfQyVY0VCoM/6m51d6w5Q6OduvOEm9VhI47CkieaiebAz8 OECavcDFnqp9HUcrSKyucjAehyDgHkEbOSv4QjoCKck4MKwgaW9Ihg5nEmqgX7ggm7Us NPcToavONOgWumInx391Gd9Pw2BiG4Axqd2FSO7vLgZKzsJ/71A7cLIU2ztJ0cLQuo2N BClw== X-Gm-Message-State: AOAM532ONNrc0MMO2YpEzN/onDMW6J9/vKyyM+HNMnDLFptofvASjpoM VEIYKPXNTqvj+wA2VV7cs2gt X-Google-Smtp-Source: ABdhPJyjQ6GZZJoJRyagZhH54C4QKhvxfpkhhMoV+tLj6HZteNgXdIk8zdBcMjpHuuRYzdhPTKGsuA== X-Received: by 2002:a63:5c43:0:b0:39d:5e18:9d98 with SMTP id n3-20020a635c43000000b0039d5e189d98mr1258791pgm.145.1649617613542; Sun, 10 Apr 2022 12:06:53 -0700 (PDT) Received: from takamaka.home ([184.69.131.86]) by smtp.gmail.com with ESMTPSA id s14-20020a63dc0e000000b0039cc76bda79sm10272634pgg.40.2022.04.10.12.06.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Apr 2022 12:06:52 -0700 (PDT) Received: by takamaka.home (Postfix, from userid 1000) id 0E425A58BF; Sun, 10 Apr 2022 12:06:52 -0700 (PDT) Date: Sun, 10 Apr 2022 12:06:52 -0700 From: Joel Brobecker To: Eli Zaretskii Cc: aburgess@redhat.com, ssbssa@yahoo.de, pedro@palves.net, gdb-patches@sourceware.org, brobecker@adacore.com Subject: Re: GDB 12.0.90 available for testing Message-ID: References: <83fsmx59wi.fsf@gnu.org> <83ee2h59m2.fsf@gnu.org> <87pmm096dc.fsf@redhat.com> <83zgl44w1m.fsf@gnu.org> <1379565857.1750775.1648990951974@mail.yahoo.com> <1113857996.1779276.1648999598328@mail.yahoo.com> <83czhyfa8i.fsf@gnu.org> <83wng1b161.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Apr 2022 19:06:56 -0000 > > Can we please finalize the fix for this? The following patch, which > > is a variation on the patch that Andrew sent, works for me. If there > > are no objections, I'd like to install it on both branches (with a > > suitable log message describing the misbehavior on MS-Windows). > > The patch seems reasonable to me, but this is only FWIW, as I do not > have good knowledge of this area. > > I'd like to do some testing, to see if I can reproduce the issue > you've seen, since Hannes was also able to reproduce. And I will > also try to test your patch in our setup as well. For the record, I did some testing using the gdb-12-branch, and unlike Hannes, I wasn't able to reproduce. I tried in various scenarios: - CMD windows - ConEmu - Cygwin terminal (there at least, I know it's not a real tty, FWIW). This was done on Windows Server 2016 (IIUC, this would correspond to a version of Windows 10, verson 1607). Since Tom already tested the patch being proposed, other than Pedro's question about the comment being removed, I'm OK with the patch being pushed to both master and gdb-12-branch. -- Joel