Re: [PATCH] Powerpc, fix vla-optimized-out.exp test

[Joel Brobecker <brobecker@adacore.com>]

Hello Carl,

Thanks for the patch.

> Powerpc, fix vla-optimized-out.exp test
> 
> The size of the variable a is not optimized out on Intel inspite of the
> use of the variable use being optimized out.
> 
> On Powerpc, the use of variable a and the size of variable a are both
> optimized out.

For me, it would be useful to include an annotated copy of the DWARF
info being produced on x86_64-linux where the size is available,
vs the DWARF being produced on PowerPC. This will help understand
what's happening and confirm that it is indeed valid for GDB to
print that the size has been optimized out.

> The output on Powerpc is:
> 
> p sizeof (a)
> $2 = <optimized out>
> (gdb) FAIL: gdb.base/vla-optimized-out.exp: o1: printed size of optimized out vla
> 
> This patch changes the gdb_test to check for the size of vla being
> available or optimized out.  In either case, the test now passes.
> ---
>  gdb/testsuite/gdb.base/vla-optimized-out.exp | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/gdb/testsuite/gdb.base/vla-optimized-out.exp b/gdb/testsuite/gdb.base/vla-optimized-out.exp
> index b16142ee329..0a25788cb34 100644
> --- a/gdb/testsuite/gdb.base/vla-optimized-out.exp
> +++ b/gdb/testsuite/gdb.base/vla-optimized-out.exp
> @@ -40,8 +40,10 @@ proc vla_optimized_out {exe_suffix options} {
>  	" = <optimized out>" \
>  	"printed optimized out vla"
>  
> +    # On Intel the variable use of variable a is optimized out but the size is
> +    # available.  On Powerpc, the variable and the size of a are optimized out.
>      gdb_test "p sizeof (a)" \
> -	" = ($sizeof_result)" \
> +	"( = ($sizeof_result)| = <optimized out>)" \
>  	"printed size of optimized out vla"

In situations like these, I would suggest using gdb_test_multiple
instead. I think it'll make the testcase more readable.

-- 
Joel