From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by sourceware.org (Postfix) with ESMTPS id 39FB53858D1E for ; Sun, 17 Apr 2022 17:34:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 39FB53858D1E Received: by mail-pj1-x1029.google.com with SMTP id h15-20020a17090a054f00b001cb7cd2b11dso12196470pjf.5 for ; Sun, 17 Apr 2022 10:34:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=W67cpab21F9Qd3WORHKvEtWT+g1NYEiuG8WjBmjfZHY=; b=mdlYZ3yfrcOJ48uQAYEqMNkBqQtL73Ni9B+bSgNR7nPcDnyMr5Q1i26q+ePb9U2RWM 1K7mP9HjDLap3NQ30E2NUOPKJ4GUQ5pXhm15dKMXGq1Cu/GumMOqZSi3rUBCWzwkwNNO VOHSR+acnxy9AlYmLNV8CFKBJSVrdB8QXbVAB7O1+SM0GqGYW9qKXneNXAouDgoR9ON1 NaI1LFzqsHhkeOB/DRmYdWNHBlWPqXIQ3yB12K2WVFLdjh98Vxa/m+0aOYLs18KknTT3 4mI8QuWNCSFoxay1Aw7mydsvE9Tf4ZJzl+tzAjbxCowE9y9oRz5CVdZFrK8ml7R7Z9JO iLlA== X-Gm-Message-State: AOAM530PoF1k+Q/i94jFqh0m9/5zKacJi6phGD7vceJcs++zpgpe6acm 0NVXSo2Ewg9cOiVPXufbuB0x X-Google-Smtp-Source: ABdhPJyxmcZWBpHMCVzFnkUaB+Bj/8AMIEep7wvaVooY0iZ8C1P6W2osqVj+MnjhPYmxdYS7ffunQg== X-Received: by 2002:a17:902:7045:b0:157:144:57c5 with SMTP id h5-20020a170902704500b00157014457c5mr7457997plt.86.1650216841351; Sun, 17 Apr 2022 10:34:01 -0700 (PDT) Received: from takamaka.home ([184.69.131.86]) by smtp.gmail.com with ESMTPSA id f33-20020a631021000000b0039dbae3fce0sm10538408pgl.43.2022.04.17.10.34.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Apr 2022 10:34:00 -0700 (PDT) Received: by takamaka.home (Postfix, from userid 1000) id EDB7AA7575; Sun, 17 Apr 2022 10:33:59 -0700 (PDT) Date: Sun, 17 Apr 2022 10:33:59 -0700 From: Joel Brobecker To: "Jose E. Marchesi" , binutils@sourceware.org Cc: Luis Machado , Joel Brobecker , gdb-patches@sourceware.org, vapier@gentoo.org Subject: Re: GDB 12.0.90 available for testing Message-ID: References: <20220320055815.2A90FA4D6C@takamaka.home> <87pmllq7jr.fsf@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87pmllq7jr.fsf@oracle.com> X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Apr 2022 17:34:04 -0000 Adding binutils@ to the list, since opcode is part of binutils. Can someone take a look at Luis' patch below, please? Luis noticed this when he tried to build the GDB 12 release candidate with --enable-target=all. Thank you! On Wed, Apr 13, 2022 at 06:20:24PM +0200, Jose E. Marchesi wrote: > > > This particular combination of switches and host has not been built in > > a while, so bugs might've been introduced/uncovered. > > > > Mike, Jose, does this look reasonable? > > Sure, for BPF. > > I wonder how we missed TARGET32_LIBOCODES_CFILES back when we integrated > the bpf backend... > > Thanks for fixing this. > > > From 387ef2492403c89ac7ac817488a49a3fd7d9d4ba Mon Sep 17 00:00:00 2001 > > From: Luis Machado > > Date: Wed, 13 Apr 2022 11:39:36 +0100 > > Subject: [PATCH] Fix 32-bit build for --enable-targets=all > > > > The following fixes the GDB build for 32-bit (tested on 32-bit arm) > > for the following combinations: > > > > * --enable-targets=all --disable-sim > > * --enable-targets=all > > > > I do see quite a few internal errors when running > > gdb.base/all-architectures.exp on arm 32-bit Ubuntu 18.04. They all > > fail when checking for a default disassembling function, which doesn't > > exists for some targets. > > > > This particular combination of switches has not been tested for 32-bit > > hosts in a while (since November/December 2021), so there might be bugs > > that we need to address. The patch makes things build cleanly though. > > > > Tested on aarch64-linux Ubuntu 20.04 and armhf-linux-gnueabi Ubuntu 18.04. > > > > It would be nice to exercise this on other 32-bit targets. > > --- > > opcodes/Makefile.am | 10 ++++++++++ > > opcodes/Makefile.in | 10 ++++++++++ > > 2 files changed, 20 insertions(+) > > > > diff --git a/opcodes/Makefile.am b/opcodes/Makefile.am > > index afd19fa7785..681fbc07584 100644 > > --- a/opcodes/Makefile.am > > +++ b/opcodes/Makefile.am > > @@ -124,6 +124,11 @@ TARGET32_LIBOPCODES_CFILES = \ > > arm-dis.c \ > > avr-dis.c \ > > bfin-dis.c \ > > + bpf-asm.c \ > > + bpf-desc.c \ > > + bpf-dis.c \ > > + bpf-ibld.c \ > > + bpf-opc.c \ > > cgen-asm.c \ > > cgen-bitset.c \ > > cgen-dis.c \ > > @@ -178,6 +183,9 @@ TARGET32_LIBOPCODES_CFILES = \ > > lm32-ibld.c \ > > lm32-opc.c \ > > lm32-opinst.c \ > > + loongarch-opc.c \ > > + loongarch-dis.c \ > > + loongarch-coder.c \ > > m10200-dis.c \ > > m10200-opc.c \ > > m10300-dis.c \ > > @@ -234,6 +242,8 @@ TARGET32_LIBOPCODES_CFILES = \ > > ppc-opc.c \ > > pru-dis.c \ > > pru-opc.c \ > > + riscv-dis.c \ > > + riscv-opc.c \ > > rl78-decode.c \ > > rl78-dis.c \ > > rx-decode.c \ > > diff --git a/opcodes/Makefile.in b/opcodes/Makefile.in > > index 3ab8bfb0548..d3eee49b169 100644 > > --- a/opcodes/Makefile.in > > +++ b/opcodes/Makefile.in > > @@ -516,6 +516,11 @@ TARGET32_LIBOPCODES_CFILES = \ > > arm-dis.c \ > > avr-dis.c \ > > bfin-dis.c \ > > + bpf-asm.c \ > > + bpf-desc.c \ > > + bpf-dis.c \ > > + bpf-ibld.c \ > > + bpf-opc.c \ > > cgen-asm.c \ > > cgen-bitset.c \ > > cgen-dis.c \ > > @@ -570,6 +575,9 @@ TARGET32_LIBOPCODES_CFILES = \ > > lm32-ibld.c \ > > lm32-opc.c \ > > lm32-opinst.c \ > > + loongarch-opc.c \ > > + loongarch-dis.c \ > > + loongarch-coder.c \ > > m10200-dis.c \ > > m10200-opc.c \ > > m10300-dis.c \ > > @@ -626,6 +634,8 @@ TARGET32_LIBOPCODES_CFILES = \ > > ppc-opc.c \ > > pru-dis.c \ > > pru-opc.c \ > > + riscv-dis.c \ > > + riscv-opc.c \ > > rl78-decode.c \ > > rl78-dis.c \ > > rx-decode.c \ -- Joel