From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id A8C943858D1E for ; Wed, 20 Apr 2022 17:11:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A8C943858D1E Received: by mail-pf1-x432.google.com with SMTP id j6so211802pfe.13 for ; Wed, 20 Apr 2022 10:11:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VBXpBnE8f0Hb1+YOSXcgAgXJCTS/bTCYNTnYHN8+LaE=; b=0vtwRVnNoZT+LKYRph5K/MYD1JaXOUTvbdsSj9Il8ByNt+ujN/iyTd2HhzvjHx8Mkj p0+zmMGodCmZzELaVUr4Xuatyzf/MCcdf38ZEgvHm0ZmNa6ru0BAXIPjiBRhQEAJh2PM CgnA6TAXI6oUyuiJs1y940bk/5m+5E2bvJJ+PcC6lAW1wFV3p88yntBL7KoLdFWfwK90 RFGqTiGJyZjwvb1yQtSMkfwrAmLWxUHP1AdRnVdJ9dqhUc5FiN37673nfRCjsT6P03Lz 3EOZTdg9Swv3s+0zrezcXpfaTBMZkpZsTjJp/hA5K2eI8eIFtjEW4grscJiGKpL0DEo3 n5xA== X-Gm-Message-State: AOAM533ZGqhp7fVydzsxJcEB8T6AwzXhDSZyjDy9u+nbIrwa6qY7F3IA xFHcqkW1ZI861k2WvjePGHt/vL/RgJSL X-Google-Smtp-Source: ABdhPJw9PThAAhGba4p0DzPienb8SWC3fFMSDK2e3ENfnNLgVax8DVLz4rLsSWE+DPSA2tls4nocag== X-Received: by 2002:a63:cd07:0:b0:39d:a6cd:cf72 with SMTP id i7-20020a63cd07000000b0039da6cdcf72mr19906071pgg.421.1650474698409; Wed, 20 Apr 2022 10:11:38 -0700 (PDT) Received: from takamaka.home ([184.69.131.86]) by smtp.gmail.com with ESMTPSA id v16-20020a62a510000000b0050759c9a891sm20096677pfm.6.2022.04.20.10.11.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 10:11:37 -0700 (PDT) Received: by takamaka.home (Postfix, from userid 1000) id 9DDD9A4A59; Wed, 20 Apr 2022 10:11:36 -0700 (PDT) Date: Wed, 20 Apr 2022 10:11:36 -0700 From: Joel Brobecker To: Eli Zaretskii Cc: Andrew Burgess , gdb-patches@sourceware.org, brobecker@adacore.com, pedro@palves.net Subject: Re: GDB 12.0.90 available for testing Message-ID: References: <1113857996.1779276.1648999598328@mail.yahoo.com> <83czhyfa8i.fsf@gnu.org> <83wng1b161.fsf@gnu.org> <83tuaz6e3x.fsf@gnu.org> <874k2prr1c.fsf@redhat.com> <838rs1ujzd.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <838rs1ujzd.fsf@gnu.org> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2022 17:11:41 -0000 Hi Eli, > > How does the patch below look? This moves the setbuf call into a new > > function, and includes the comment from gdb_readline_no_editing_callback. > > Thanks. However, the patch that I tested only used the ISATTY test in > ui::ui, not in read_command. Not sure if that matters. Would you mind testing this new patch to see if it still works? -- Joel