From: Mike Frysinger <vapier@gentoo.org>
To: Sergei Trofimovich <slyich@gmail.com>
Cc: gdb-patches@sourceware.org, Sergei Trofimovich <siarheit@google.com>
Subject: Re: [PATCH] sim: fix BFD_VMA format arguments on 32-bit hosts
Date: Tue, 7 Jun 2022 01:15:48 -0400 [thread overview]
Message-ID: <Yp7fBHOOZx2rr8hf@vapier> (raw)
In-Reply-To: <20220521075917.1353792-1-slyich@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 873 bytes --]
On 21 May 2022 08:59, Sergei Trofimovich via Gdb-patches wrote:
> --- a/sim/cris/sim-if.c
> +++ b/sim/cris/sim-if.c
these BFD_VMA_FMT changes look fine
> --- a/sim/m32c/syscalls.c
> +++ b/sim/m32c/syscalls.c
>
> - printf ("gettimeofday: %ld sec %ld usec to 0x%x\n", tv.tv_sec,
> - tv.tv_usec, tvaddr);
> + printf ("gettimeofday: %lld sec %lld usec to 0x%x\n",
> + (long long)tv.tv_sec, (long long)tv.tv_usec, tvaddr);
>
> --- a/sim/rx/syscalls.c
> +++ b/sim/rx/syscalls.c
>
> - printf ("gettimeofday: %ld sec %ld usec to 0x%x\n", tv.tv_sec,
> - tv.tv_usec, tvaddr);
> + printf ("gettimeofday: %lld sec %lld usec to 0x%x\n",
> + (long long)tv.tv_sec, (long long)tv.tv_usec, tvaddr);
i think using explicit 64-bit types (i.e. int64_t) rather than long long
would be better. it's what we used in other places so far (like the sim
callback APIs).
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-06-07 5:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-21 7:59 Sergei Trofimovich
2022-06-07 5:15 ` Mike Frysinger [this message]
2022-06-08 6:43 ` [PATCH v2] " Sergei Trofimovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp7fBHOOZx2rr8hf@vapier \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=siarheit@google.com \
--cc=slyich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).