From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184])
 by sourceware.org (Postfix) with ESMTPS id C19DE3857011
 for <gdb-patches@sourceware.org>; Thu, 21 Jul 2022 12:36:28 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C19DE3857011
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org
Received: from reform (213-10-231-91.fixed.kpn.net [213.10.231.91])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id 87681300047C;
 Thu, 21 Jul 2022 14:36:24 +0200 (CEST)
Received: by reform (Postfix, from userid 1000)
 id 365402E81645; Thu, 21 Jul 2022 14:36:23 +0200 (CEST)
Date: Thu, 21 Jul 2022 14:36:23 +0200
From: Mark Wielaard <mark@klomp.org>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org, Kevin Buettner <kevinb@redhat.com>
Subject: Re: [PATCH][gdb] Fix python selftest with python 3.11
Message-ID: <YtlIR6mkhmghbhBs@wildebeest.org>
References: <20220721111316.GA23728@delia.home>
 <20220721114239.GB7014@gnu.wildebeest.org>
 <716feba4-7ca1-dc46-12b3-e7a895956d8b@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <716feba4-7ca1-dc46-12b3-e7a895956d8b@suse.de>
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, KAM_NUMSUBJECT, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Jul 2022 12:36:30 -0000

Hi Tom,

On Thu, Jul 21, 2022 at 02:06:09PM +0200, Tom de Vries wrote:
> > It seems the line number is really irrelevant here for where exactly
> > the KeyboardInterrupt took place. So the patch looks good to me.
> > 
> 
> Thanks for the review.
> 
> > Note that there is a gdb-try-rawhide-x86_64 builder, so you can also
> > test by pushing this to a git users/vries/try-xxx branch.
> 
> I've tried that, and it went fine, so I've pushed this (after fixing a
> trivial formatting issue, not reposting).

I am afraid the trivial formatting fix accidentially introduced an
extra space before KeyboardInterrupt:

" KeyboardInterrupt\n" should be "KeyboardInterrupt\n"

Cheers,

Mark