From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id A8DB43858297 for ; Wed, 14 Sep 2022 08:38:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A8DB43858297 Received: by mail-ej1-x636.google.com with SMTP id 13so4022554ejn.3 for ; Wed, 14 Sep 2022 01:38:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=UtxtvjtTp2WHX0qxFUJ8nGTzRWHGQZks129Tzjr4M8o=; b=UPid75KJn8yqloHlx1LgEgLlSqwDTzd7yQHpzZ8NG98iZvLBnqJ3XiSDttRUhI2H57 AA43wmYjCF5cPht06VdVZqZbzjljXdYTYSSJ0yYiyvWkc+5Tv4bvjupwxzWvgdLQdU1H RFIGFJ/Ao7nz6Mxfu6cZV8b3Bvw8LtxECoNTOM3Pe1S0+z60mkaUT0/9lF6CIDvtSApS RbwGUJ29maCX/vz1QzPmtkK8u2omUfmk00JX3DdfEioykBuVx7+LkGwvtd3UKpSJJHdL KqEOoajm+xEiDlCdx8o9Yf0KA956EYUJKBQgVQD8vXSJLI8biZBX766UqfezZgOe1/mK rjLg== X-Gm-Message-State: ACgBeo3rFTfMzj6e5sZ85jk70QuSxse2uBfDYBRkMjdIGi1l9e9qOy2J i4Y7Fy5ILXYKiVGVfZ9aX3tn X-Google-Smtp-Source: AA6agR58HU+8+oFF7d1bYuONVdszfNgChGbsxts6greFgKp7kKzYbGWcPjwRBZiRyyOj5o4SB8TVow== X-Received: by 2002:a17:907:320a:b0:741:72ee:8f3 with SMTP id xg10-20020a170907320a00b0074172ee08f3mr25074315ejb.168.1663144680515; Wed, 14 Sep 2022 01:38:00 -0700 (PDT) Received: from takamaka.gnat.com ([45.147.211.82]) by smtp.gmail.com with ESMTPSA id ly9-20020a170906af4900b0073dde62713asm7360421ejb.89.2022.09.14.01.38.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Sep 2022 01:38:00 -0700 (PDT) Received: by takamaka.gnat.com (Postfix, from userid 1000) id 9E6B489F2E; Wed, 14 Sep 2022 10:37:59 +0200 (CEST) Date: Wed, 14 Sep 2022 10:37:59 +0200 From: Joel Brobecker To: "Metzger, Markus T" Cc: Tom Tromey , "gdb-patches@sourceware.org" , Kevin Buettner , "brobecker@adacore.com" Subject: Re: [PATCH v5 08/15] gdb, ada: collect standard exceptions in all objfiles Message-ID: References: <20220602132514.957983-1-markus.t.metzger@intel.com> <20220602132514.957983-9-markus.t.metzger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Sep 2022 08:38:03 -0000 Hi Markus, > would you be able to review this patch? I think Tom already reviewed this patch (back in July), and he said it looked fine to him. Here is the link to the email, in case I am mistaken: https://sourceware.org/pipermail/gdb-patches/2022-July/190855.html > >-----Original Message----- > >From: Metzger, Markus T > >Sent: Montag, 18. Juli 2022 07:36 > >To: brobecker@adacore.com > >Cc: gdb-patches@sourceware.org; Kevin Buettner > >Subject: RE: [PATCH v5 08/15] gdb, ada: collect standard exceptions in all objfiles > > > >Hello Joel, > > > >Would you be able to review this Ada-related patch? > > > >thanks, > >markus. > > > >>-----Original Message----- > >>From: Metzger, Markus T > >>Sent: Donnerstag, 2. Juni 2022 15:25 > >>To: gdb-patches@sourceware.org > >>Subject: [PATCH v5 08/15] gdb, ada: collect standard exceptions in all objfiles > >> > >>When searching for standard exceptions for Ada, we lookup the minimal > >>symbol of each exception. With linker namespaces there can be multiple > >>instances in different namespaces. Collect them all. > >>--- > >> gdb/ada-lang.c | 30 +++++++++++++++++++++++------- > >> 1 file changed, 23 insertions(+), 7 deletions(-) > >> > >>diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c > >>index 6ab01fd27d4..2b251693b72 100644 > >>--- a/gdb/ada-lang.c > >>+++ b/gdb/ada-lang.c > >>@@ -13016,15 +13016,29 @@ ada_add_standard_exceptions (compiled_regex > >>*preg, > >> { > >> if (preg == NULL || preg->exec (name, 0, NULL, 0) == 0) > >> { > >>- struct bound_minimal_symbol msymbol > >>- = ada_lookup_simple_minsym (name); > >>+ symbol_name_match_type match_type = name_match_type_from_name > >>(name); > >>+ lookup_name_info lookup_name (name, match_type); > >> > >>- if (msymbol.minsym != NULL) > >>- { > >>- struct ada_exc_info info > >>- = {name, msymbol.value_address ()}; > >>+ symbol_name_matcher_ftype *match_name > >>+ = ada_get_symbol_name_matcher (lookup_name); > >> > >>- exceptions->push_back (info); > >>+ /* Iterate over all objfiles irrespective of scope or linker > >>+ namespaces so we get all exceptions anywhere in the > >>+ progspace. */ > >>+ for (objfile *objfile : current_program_space->objfiles ()) > >>+ { > >>+ for (minimal_symbol *msymbol : objfile->msymbols ()) > >>+ { > >>+ if (match_name (msymbol->linkage_name (), lookup_name, > >>+ nullptr) > >>+ && msymbol->type () != mst_solib_trampoline) > >>+ { > >>+ ada_exc_info info > >>+ = {name, msymbol->value_address (objfile)}; > >>+ > >>+ exceptions->push_back (info); > >>+ } > >>+ } > >> } > >> } > >> } > >>@@ -13122,6 +13136,8 @@ ada_add_global_exceptions (compiled_regex *preg, > >> SEARCH_GLOBAL_BLOCK | SEARCH_STATIC_BLOCK, > >> VARIABLES_DOMAIN); > >> > >>+ /* Iterate over all objfiles irrespective of scope or linker namespaces > >>+ so we get all exceptions anywhere in the progspace. */ > >> for (objfile *objfile : current_program_space->objfiles ()) > >> { > >> for (compunit_symtab *s : objfile->compunits ()) > >>-- > >>2.35.3 > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 > -- Joel