From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id 3303D3858C2B; Wed, 10 May 2023 00:56:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3303D3858C2B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1aaf7067647so45867765ad.0; Tue, 09 May 2023 17:56:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683680215; x=1686272215; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FY0mtxLOO4dldeKV4e8rGfaNZJh9YfHCvj4lqRFPa4E=; b=l5v2gnwtBQtwPbuBi04mL7i9kSIjy/lSl+EOn0yLvfGGyOZ9v5Z9GtKBvbf8zQKZGZ PQYpHPScmlPQ6NGy35Jd5sJlvt2BRfl5ZZ/hrzFr/gvQDoRl7m4hFk8wwkjBOqfqU2+b zzm79/osoTpidkW2yMVlv/HbcMSyZZhcEK+uX9UBtaAEflRvRsaoOXbMwHlcAVOCkwcG HbvcNfuuCcjicXLQsrW1qNJXFsnlXXqXDl/lSi5FuagYXnRfV35zbY9VyaLqDh3TsZ9G HYuqIt0pbubvkkroPno84w2ppce1rxJ3HvknXrd8q6r+Xg9saevIUPGpj88cnFBiU83f A7Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683680215; x=1686272215; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FY0mtxLOO4dldeKV4e8rGfaNZJh9YfHCvj4lqRFPa4E=; b=L+sDDCtrQGUvi0rNMo+vC/vJX7rZktrqu8wfegFWUyMKwu+XULaTBoKLwp4sUmGXmD VJUCVCYvagHXs9VQTh2+wuAG/ZoCpC3gg93ruJxC6nN6nCtOCqdnxfzo4xRjn/QpciqB Y1DB5xANpfH6i92IZmTvHC7tm5I4d9eU4q3A+M/PtQEnB5rSz0E+SY1eUv5141p+AMoT oMV8cGr4Giy4j5oiAKvb3SqH+3iqJD4b1Z3p8K8zblSJL6glSdSoMrDlmVxxeMtihnfL mBdT6VlJ+1qbnM1NUHeYJyHxau8mvFfFI4rMaobcKQBbHanLzeem+JA0yI5khUBnVHDI 1Xfw== X-Gm-Message-State: AC+VfDzlCjhfS35yf8JedfiG6cT+9231YGSsKeXeg6xb1qqQIioLHmHb oCDuxowEY2VxZlKymMRJtcgogtsDv8w= X-Google-Smtp-Source: ACHHUZ648sUYOAXZ2kJkcTl8OGhbhU4Xfn1zIrvi4dQV3t2JUxeaZHnlfA2brhQtV/wWfMZIlc6uog== X-Received: by 2002:a17:902:e845:b0:1ac:63ac:109d with SMTP id t5-20020a170902e84500b001ac63ac109dmr14706483plg.15.1683680214989; Tue, 09 May 2023 17:56:54 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id 17-20020a170902ee5100b001a63ba28052sm2292749plo.69.2023.05.09.17.56.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 May 2023 17:56:54 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id C9C18114087E; Wed, 10 May 2023 10:26:51 +0930 (ACST) Date: Wed, 10 May 2023 10:26:51 +0930 From: Alan Modra To: Mark Harmstone Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] pdb: Allow loading by gdb Message-ID: References: <20230509003247.24156-1-mark@harmstone.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230509003247.24156-1-mark@harmstone.com> X-Spam-Status: No, score=-3028.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, May 09, 2023 at 01:32:46AM +0100, Mark Harmstone wrote: > Add a new bfd_flavour value, and expose PDB files as objects, so that > they get accepted by add-symbol-file. By equating object_p and archive_p you are going to get whichever of bfd_archive or bfd_object is tried first as the argument of bfd_check_format (or bfd_check_format_matches). This seems fragile to me. We have multiple binary utilities, ld, and gbd all calling bfd_check_format. Do they all work correctly with this change, and will they continue to work correctly with future changes? I think you'd be better off staying with just one format, and bfd_archive probably fits pdb files better than bfd_object. -- Alan Modra Australia Development Lab, IBM