From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 1E6613858288 for ; Wed, 16 Aug 2023 03:08:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E6613858288 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-68891000f34so52642b3a.0 for ; Tue, 15 Aug 2023 20:08:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692155280; x=1692760080; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1Z+j15sq9zD71JShG7XWxDvpsDHLJ7XfLBBqRzj/Okk=; b=UtEmnvwMx97b1KBoUIJ1Bu1xQ78CH0Z/JC2R3DYFzhEStxbFTwqNiOXac5RI8vA5GE 7xZNZVii6G3DXzOH2/0pCALtipdm6fO9AY7cH90sWU6qosh2f37Xd1lAuejJil3cjbZr Qx4WP11IBdrKY8tfUT1xrixqlhvqzo6gyU5TMWIV9ZC52QWnOOh5lV5ia6LlVEdcTcW6 UeANQgpGFEJzqP06rxIKunG+tcv3L7u4A45PnO/mSlJDUbcmNTkwpbt6h01p9fVmUItw Pxeaq6bDjYJXsyih7dkEK+df3Sc4wSjjjkmJU12BxN1EHszbM6mQlPw7YUuCvj+TNCm/ zpnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692155280; x=1692760080; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1Z+j15sq9zD71JShG7XWxDvpsDHLJ7XfLBBqRzj/Okk=; b=aY092E6aIcS9QXR6iBMowmG/18gTYVgfAOTO9yAGjKqtxhuzib7VRvRusz3vHLQE/d HqqW2PA1DZxQfOjDYYo4Sh1iC4K2GQesO9ndirWlcunFW1t6Iznve5dcbWl31paG+dJo B01M46nWYyC84sTDV7xlL4R3inWiW6mOyOAf2QQUJ61jEvywNB7Msk7H1lHbygPaqSGj qkJhWg9v8deXCHRTubegm1EUZK8lhYzvKpqyhEfCcR6EBUIcSgDyS6ddommejh1rJ7nX u0l9nygB0L/BZPKQMN+37BmyTEqDqew81Hq2lKFs3p96t6B5n1EmgGFX38UT/77WvOK3 cpoQ== X-Gm-Message-State: AOJu0Yyt6QS9OEKD77TxI4Bj2z1l681202BfBPWPl2zjxPUEBUItz9Go aOtGdSxE7SgolcW+DPYjkvig1kun+N0= X-Google-Smtp-Source: AGHT+IG3ITqxm/Z/bESOg7B6kFlfmiNEsGDdFA/Co4woFfn29xO9yZtgAdBk68IWI2mePN0LMxIsDA== X-Received: by 2002:a05:6a00:c89:b0:682:2e99:9de0 with SMTP id a9-20020a056a000c8900b006822e999de0mr800974pfv.23.1692155279980; Tue, 15 Aug 2023 20:07:59 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id fm22-20020a056a002f9600b00688459a9bdcsm1931043pfb.135.2023.08.15.20.07.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Aug 2023 20:07:59 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 219AF114001C; Wed, 16 Aug 2023 12:37:56 +0930 (ACST) Date: Wed, 16 Aug 2023 12:37:56 +0930 From: Alan Modra To: Tom Tromey Cc: gdb-patches@sourceware.org, aburgess@redhat.com Subject: Re: sim regen preparation Message-ID: References: <87a5utzj2z.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a5utzj2z.fsf@tromey.com> X-Spam-Status: No, score=-3028.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Aug 14, 2023 at 10:26:12AM -0600, Tom Tromey wrote: > >>>>> "Alan" == Alan Modra via Gdb-patches writes: > > Alan> Regerating sim loses commit 1be79b1ebfad from sim/lm32/cpu.h, a > Alan> generated file, so this patch move those declarations to > Alan> sim/lm32/sim-main.h. > > In other spots in gdb we stick a read-only header on generated files to > avoid this sort of error, like: > > /* THIS FILE IS GENERATED -*- buffer-read-only: t -*- */ > /* vi:set ro: */ > > Pity cgen doesn't do this. Yes, that would be nice. Along with a whole lot of other things. :) > Alan> OK to apply? > > I don't mind the patch at all but I wonder why cgen generates calls to > these functions but not declarations for them; whereas for other > functions (e.g., "lm32bf_h_pc_get") it does generate the declarations. I'm not curious enough to dive down that rabbit hole, sorry. The sim patches I posted were enough for me to regen and run the testsuite, so that eg. cpu/ patches can be regression tested on sim targets. I also looked at regenerated files in enough detail to convince myself that the changes, in particular to iq2000, were reasonable. Note that people might have thought they were testing sim, but "make check" in sim doesn't do much unless you set up site-sim-config.exp, or have a lot of AS_FOR_TARGET_$arch, LD_FOR_TARGET_$arch and CC_FOR_TARGET_$arch in your environment. Also, linker warnings render many of the tests "UNTESTED". Only the latter is fixed, and of course only for current warnings. -- Alan Modra Australia Development Lab, IBM