From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id 526C6385DC11 for ; Wed, 16 Aug 2023 13:20:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 526C6385DC11 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1bdb7b0c8afso29692745ad.3 for ; Wed, 16 Aug 2023 06:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692192023; x=1692796823; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oNscZrReeiMz6n2yLZDC/DjeZyQ5FLVmW01kE49kokI=; b=mhLZDxg/7gS6fKftG9yK7FZ0I1fT1/HIsj5fO7eRo85H7GoyvB9LefeIgh6TszZtuS NXVcGQtmQg0Ak02iDEpUR4U8OwZ3YgkIRflw7ku+BN8AFY7FpklUwDbD5UwHMmoGj/BE dIDlVftNDlSEPKUwhzpzc5VoaSLZrCsiNBu7k+2lcyDzd1Xh0v0uTx5NAxj5Q85h7SVp 5oRDSmR4MX5MQ507/o5b676QjrUUG2s/bYS3LkznT5VDsLadI4B/jdeDgziYDPahK26y tfHegCVuG+/z2Ls/jY7zoa6pyZYBgtZzKGCLcTRO1Wwjt0TyqBcTC1ME+LbrL8sYmtpV W3hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692192023; x=1692796823; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oNscZrReeiMz6n2yLZDC/DjeZyQ5FLVmW01kE49kokI=; b=bjJRqbLNwBTRbN65wHmsYpOEX/jOlGkrKsvp8e2fM/VsC7wY99FsZUzAq2G1n+MhgM EDfu4gtOnNIu7guw1MapsYZnBioMpBUtzNryLtrUiES0JNYfU3Nj35nbngJcUZZZNosy 2GRdIOH1WXDEpXKhgV8qbYJZfYkraQ7zq88yls6Opvp2NBDRH0Q2LLVYmQJx4s71FL/G ABVpDMblz/KK5TGiMdRe72LDXyY9fLDkyGM0OgBrxOhG99cdbTxhuroGWwgxEhSgn3xJ bzPwei10JDb6xXfVHFTuf5hoH/jn9o7dP8rypQxmvqHUa8+N99q6xct6mXlWfWijGKAd XB/Q== X-Gm-Message-State: AOJu0YyGr91tQ+wZeRv2i15SXkZjkyekLY5kuPh70aGuOILVsT/ZRHIt Db+/gZtVDaDK1nA8/yfTcnU= X-Google-Smtp-Source: AGHT+IGapt60ChLALfC4xMYw1Kcsa19gpcWUZ555PLBP6waHQYrGaT7Lk2VIFYdbiUm4g2IyVrZ2nA== X-Received: by 2002:a17:903:26c2:b0:1bd:ed26:d2c6 with SMTP id jg2-20020a17090326c200b001bded26d2c6mr1599009plb.4.1692192023135; Wed, 16 Aug 2023 06:20:23 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id q3-20020a170902788300b001bbd8cf6b57sm13130431pll.230.2023.08.16.06.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Aug 2023 06:20:22 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 81EA51142572; Wed, 16 Aug 2023 22:50:19 +0930 (ACST) Date: Wed, 16 Aug 2023 22:50:19 +0930 From: Alan Modra To: Sam James Cc: Tom Tromey , aburgess@redhat.com, gdb-patches@sourceware.org Subject: Re: sim regen preparation Message-ID: References: <87a5utzj2z.fsf@tromey.com> <87y1iby78s.fsf@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y1iby78s.fsf@gentoo.org> X-Spam-Status: No, score=-3034.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Aug 16, 2023 at 04:51:13AM +0100, Sam James wrote: > > Alan Modra via Gdb-patches writes: > > > On Mon, Aug 14, 2023 at 10:26:12AM -0600, Tom Tromey wrote: > > [...] > > > > Note that people might have thought they were testing sim, but "make > > check" in sim doesn't do much unless you set up site-sim-config.exp, > > or have a lot of AS_FOR_TARGET_$arch, LD_FOR_TARGET_$arch and > > CC_FOR_TARGET_$arch in your environment. Also, linker warnings render > > many of the tests "UNTESTED". Only the latter is fixed, and of course > > only for current warnings. > > This sounds like something we should probably dump into the wiki at some > point. And to clarify a little, my comment applies to --enable-targets=all. If you are building a specific sim, eg. --target=frv-elf, then the sim test harness will look for frv-elf-as, frv-elf-ld and use those if found on $PATH. BTW, I found the commit responsible for those 155 frv fails. Fixed as follows. I'll commit as obvious tomorrow unless someone nacks it. ---- Re: sim frv: Add a missing return value for frvbf_check_acc_range. Commit f00b50d057 went the wrong way. As the comment says this function is only applicable to fr550. If not fr550 return 1, meaning we don't have acc restrictions. diff --git a/sim/frv/traps.c b/sim/frv/traps.c index dda066faec3..aee1f0e741a 100644 --- a/sim/frv/traps.c +++ b/sim/frv/traps.c @@ -747,7 +747,7 @@ frvbf_check_acc_range (SIM_CPU *current_cpu, SI regno) /* Only applicable to fr550 */ SIM_DESC sd = CPU_STATE (current_cpu); if (STATE_ARCHITECTURE (sd)->mach != bfd_mach_fr550) - return 0; + return 1; /* On the fr550, media insns in slots 0 and 2 can only access accumulators acc0-acc3. Insns in slots 1 and 3 can only access -- Alan Modra Australia Development Lab, IBM