From: Gregory Anders <greg@gpanders.com>
To: Tom Tromey <tom@tromey.com>
Cc: Gregory Anders via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 4/4] gdb/dap: only include sourceReference if file path does not exist
Date: Fri, 1 Sep 2023 21:42:59 +0000 [thread overview]
Message-ID: <ZPJa41-n5cYfg6CZ@gpanders.com> (raw)
In-Reply-To: <87jzt9of2e.fsf@tromey.com>
On Fri, 01 Sep 2023 13:42 -0600, Tom Tromey wrote:
>I suspect we should just remove all sourceReference handling from
>sources.py, because if we can't find a full path, gdb isn't going to be
>able to come up with the source anyway.
>
>What do you think?
I agree. I avoided doing this originally to keep the change small, but I
think eliminating sourceReference completely (for the reason you
mentioned) is the better approach. It will keep the code simpler.
>I thought the test suite might need some updates but I don't see any
>references to sourceReference there.
There was one test case that was failing with the v1 patch
(sources.exp). I updated it in v2 (sent a few minutes ago).
Greg
next prev parent reply other threads:[~2023-09-01 21:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 17:55 [PATCH 0/4] DAP fixups Gregory Anders
2023-09-01 17:55 ` [PATCH 1/4] gdb/dap: check for breakpoint source before unpacking Gregory Anders
2023-09-01 19:05 ` Tom Tromey
2023-09-01 19:18 ` Gregory Anders
2023-09-01 17:55 ` [PATCH 2/4] gdb/dap: ignore unused keyword args in step_out Gregory Anders
2023-09-01 19:07 ` Tom Tromey
2023-09-05 14:12 ` Gregory Anders
2023-09-01 17:55 ` [PATCH 3/4] gdb/dap: use breakpoint fullname to resolve source Gregory Anders
2023-09-01 19:08 ` Tom Tromey
2023-09-05 14:08 ` Gregory Anders
2023-09-01 17:55 ` [PATCH 4/4] gdb/dap: only include sourceReference if file path does not exist Gregory Anders
2023-09-01 19:42 ` Tom Tromey
2023-09-01 21:42 ` Gregory Anders [this message]
2023-09-01 21:56 ` Gregory Anders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPJa41-n5cYfg6CZ@gpanders.com \
--to=greg@gpanders.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).