On 30 Oct 2023 13:00, jaydeep.patil@imgtec.com wrote:
> Added support for compressed integer instruction set ("c").

i haven't been keeping up with riscv specs.  is the compressed extension
finalized ?  so you're only implementing official insns in the spec ?  i
don't think it's appropriate for the sim to implement vendor-specific
stuff at this point in time.

> Added gdb.arch/riscv-insn-simulation.c to test it.
> Added simulator tests in sim/testsuite/riscv/c-ext.s

afaict, there is no relationship between the compression & semi-hosting work.
these are just two things you're working on ?  so they don't really need to
be in the same patch series.

>  .../gdb.arch/riscv-insn-simulation.c          | 1544 +++++++++++++++++
>  .../gdb.arch/riscv-insn-simulation.exp        |   31 +

i'm missing something ... why does there need to be tests in gdb at all here ?
-mike