From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 00A973858D20 for ; Fri, 15 Dec 2023 03:46:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 00A973858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 00A973858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702612004; cv=none; b=HQcnN60Vnyaj57jJRLsoU2fU9Jpn9yMxwZ8azPT8mqFq3FD0HsuEFOegWm+RQJnQHJ1wEI06No9LreSs4qmXqab9EiBo6gvw2BV1Jl+Bv2orNI0SgEOsstEoDVcrw3TKAN3GAEWtCQCtdkAydJQiS4LtngVUpCM/gAq+cafQH7w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702612004; c=relaxed/simple; bh=fkHdq8CRHwsr2SnMO7om9OrKabN2Snrz8LwsVYZnf7w=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=B8EJVWbx34lRG7PAFnR4VlI7CGyXSG4W76iz5rqJrdAPPesYW6TChxM0OynY21mX7gM9a/TGJin1eBzTEL7kiy7/RlAkYL9PSPj5SA0vsdI5hHTV86CFQYfp/F0HvY1LCDVNc90Qk0idZO7TANG99gl4RMyhar51LlCtqwKmjf0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 9F783335DEB; Fri, 15 Dec 2023 03:46:42 +0000 (UTC) Date: Thu, 14 Dec 2023 22:46:41 -0500 From: Mike Frysinger To: Simon Marchi Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] sim: add __attribute__((unused)) to _fill_argbuf_tp function Message-ID: References: <20231214162139.8415-1-simon.marchi@efficios.com> <639d075f-157d-4b0f-ba48-2f130cacb6ec@simark.ca> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NFBI4SQROku2ygBB" Content-Disposition: inline In-Reply-To: <639d075f-157d-4b0f-ba48-2f130cacb6ec@simark.ca> X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --NFBI4SQROku2ygBB Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 14 Dec 2023 21:32, Simon Marchi wrote: > Btw, is it possible that the dependencies in m32r/local.mk are not > correct, for the various mloop files? After applying your patch, I had > to do a clean first. >=20 > The rule to generate mloop2.c is: >=20 > %D%/mloop2.c %D%/eng2.h: %D%/stamp-mloop-2 ; @true > %D%/stamp-mloop-2: $(srccom)/genmloop.sh %D%/mloop.in >=20 > Should it depend on mloop2.in instead of mloop.in? Likewise for mloopx. yeah, it should. m32r is weird in that it has multiple mloop files -- other ports that generate multiple outputs do it from a single mloop.in input. so looks like i missed that when migrating everything to local.mk. i broke it with commit 0a129eb19a773d930d60b084209570f663db2053. pushed the fix below. -mike =46rom 10802d9ac0c6e39a672f86224ec89a9a54a37b9c Mon Sep 17 00:00:00 2001 =46rom: Mike Frysinger Date: Thu, 14 Dec 2023 22:45:22 -0500 Subject: [PATCH] sim: m32r: fix mloop.in variant stamp deps The migration to local.mk in commit 0a129eb19a773d930d60b084209570f663db2053 accidentally listed the deps for all mloop steps as mloop.in instead of the various variants that m32r uses. Reported-by: Simon Marchi --- sim/Makefile.in | 4 ++-- sim/m32r/local.mk | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sim/m32r/local.mk b/sim/m32r/local.mk index 182d8879b434..13f6ea5f9570 100644 --- a/sim/m32r/local.mk +++ b/sim/m32r/local.mk @@ -105,7 +105,7 @@ BUILT_SOURCES +=3D \ =20 ## FIXME: Use of `mono' is wip. %D%/mloopx.c %D%/engx.h: %D%/stamp-mloop-x ; @true -%D%/stamp-mloop-x: $(srccom)/genmloop.sh %D%/mloop.in +%D%/stamp-mloop-x: $(srccom)/genmloop.sh %D%/mloopx.in $(AM_V_GEN)$(SHELL) $(srccom)/genmloop.sh -shell $(SHELL) \ -mono -no-fast -pbb -parallel-write -switch semx-switch.c \ -cpu m32rxf \ @@ -116,7 +116,7 @@ BUILT_SOURCES +=3D \ =20 ## FIXME: Use of `mono' is wip. %D%/mloop2.c %D%/eng2.h: %D%/stamp-mloop-2 ; @true -%D%/stamp-mloop-2: $(srccom)/genmloop.sh %D%/mloop.in +%D%/stamp-mloop-2: $(srccom)/genmloop.sh %D%/mloop2.in $(AM_V_GEN)$(SHELL) $(srccom)/genmloop.sh -shell $(SHELL) \ -mono -no-fast -pbb -parallel-write -switch sem2-switch.c \ -cpu m32r2f \ --=20 2.43.0 --NFBI4SQROku2ygBB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmV7zCEACgkQQWM7n+g3 9YHLZxAAxcBIjMP0R2gaWhI+OjShTUO1fG5htcAAE+0iFUGw+eiS/51rHHhneLUi G/D35hHK7wGXdbVxkVxL3tVz7q9ZasnJ5f4/sHNzQLBq5P+/E3U4yKCEDWvMs+OT WILyFd+81Xd0OQuzhkYGGCJYf01KVmIeFIexfLWa6vx+KyRatUe+y4fcifQNzG4v 946v+MyNJmUKTOKm5YbMcBV/vJdH7fYDVciwOjjm/JAlshgDt/QUl0FaJGcXWOKR jMSXyHOp7CJJjUpRfwPUp9bNiGUdSkB5f9ImCkmNrrpl8uUV2uOmxx2ozhvvif5Y 0uq8PrabSfpCHcdusHXh204xGffq/PVHJYCpo52KMAEeSPUl1NPbv0zLojYduWC/ JorlL6A248Ri2CmjvQnzDLBcUpGe9FQVis8BkmTbz1zzURW+YVAi6lMsZfLLa5oZ noflhMsWfUW0NJx2thZrtoK8FHViBSW0EolZu6sf5XxzmPX5p+T08EzUwNuHcqh/ i2sVIcDHB77i4IKEj9xCRtRLQfaPqOR42l2DbTcwi+0SpfQefwCDul4e/IxGKouc 5m+VsvchvSFkFBQ+fEwKPYYLLuPyB+YgvH29iQtJAYzS11fRRDJ7W4vmCcAllDnQ r1y9p/8IBqqiOfW0ClyKi4MfdwO4mYNtQy97okA50R8zLrVEWOE= =2JXy -----END PGP SIGNATURE----- --NFBI4SQROku2ygBB--