From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id D25FF38582AE for ; Mon, 18 Dec 2023 16:26:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D25FF38582AE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D25FF38582AE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702916815; cv=none; b=wYEPPAl7P4lIATB156qFAGph9cauOTFrSG7oXduf2M/i/X6oHO3f7Fi3DzzVnjEG/pEmIMH3waMyem7xpUH57isJGnn1iH1OmhDB2ziOPCA0fwrVdBSHG/5QAVVNP+uaSmk6OIOnu80q87Y/E0DXByZ8HmdtrKXua23tzw8K4OU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702916815; c=relaxed/simple; bh=AJM/LatCgpmwExQkVGrsNqg1rDgdkj79RzD3YySkINM=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=pAwrJCODW5ubh3i3GuYfBWH6DAqGTZrf7CkIVOT14UdXJ7dpzqncDktapq28OILJcFuTu3uc7TJms+IGqTKBskar19vfQPupukbwVnVGNPNXUdhipPeqq0zRRBRh9haLk8PeNwGBGthpk1M5Xmzr4MZvc/1c4tE3XE7MemuzQOI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 3429E33D3CF; Mon, 18 Dec 2023 16:26:54 +0000 (UTC) Date: Mon, 18 Dec 2023 11:26:52 -0500 From: Mike Frysinger To: jaydeep.patil@imgtec.com Cc: gdb-patches@sourceware.org, aburgess@redhat.com, joseph.faulls@imgtec.com, bhushan.attarde@imgtec.com Subject: Re: [PATCH v3 1/3] [sim/riscv] Fix crash during instruction decoding Message-ID: References: <20231217065218.3799535-1-jaydeep.patil@imgtec.com> <20231217065218.3799535-2-jaydeep.patil@imgtec.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YsSDGJP4GLcJVFZf" Content-Disposition: inline In-Reply-To: <20231217065218.3799535-2-jaydeep.patil@imgtec.com> X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --YsSDGJP4GLcJVFZf Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 17 Dec 2023 06:52, jaydeep.patil@imgtec.com wrote: > The match_never() function has been removed and thus step_once() crashes > during instruction decoding. Fixed it by checking for null pointer before > invoking function attached to match_func member of riscv_opcode structure. the opcodes code is still doing: if (! (op->match_func) (op, word)) -mike --YsSDGJP4GLcJVFZf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmWAcswACgkQQWM7n+g3 9YFjvA/8DiwPBqwgttK9FHhVhLVFl/3DTg3mxt98OrcrxXcjZdnAqYIwdVRiprgy bnZ6hjddFqhXMqGvwoq2ZeXwmjoLjE6p5HLPbBJ/mGRkBzMfbEEF4wee3nWelfod bBFS3WI+nZGi3vY6S/1LBhLigsf3RBJCjBAOimPSXbRAODFBGlqZEc2CNfv1EudC HBj3NyF6JZ4fmd4JP6UyChP1TIAe5Px5yVaPwtxwLXoVmJQf3XmcFpgk690gTlhG xmVGo4d8HhJE4bBSBGatL1W7bu3oE183cs4uFtGWRMCwIUBVHherQdmf0zEcFBx4 iD9uwpjHtKOINYec9UIfzDtaXccByfUF3PxJD+sgiiZiz3twtP7nHRcJv4ERMAIO fet8c4xWT3S9O/PDtxQiIT1klD4leXQP+nAHqc+x/yYUemVlXrvqOCDvxWlTKg1g forRUotlgEfyWYHTlm5NlvnNiI3V9LHQ3DOUU4wyT5GaghY5bCkydgML8Ep2d6LE B46mac0XuFiYxEpUgzuwXSyY3WKbxVoK8uCJjWoNcAUHLE5wRet8L4c73LcMFym0 ebuGtDLj1s6qalxu7Yz61NbOlUA9/NtnQo98rkHQgB3zizEzahBNwtfwtS+hfWwR ImergUnizVIQs343sz2oE+QGbc3HB2SnfbL1iuj2xaVWRc/C0ak= =HKkI -----END PGP SIGNATURE----- --YsSDGJP4GLcJVFZf--