From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 33A433858292 for ; Mon, 18 Dec 2023 16:29:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 33A433858292 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 33A433858292 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702916982; cv=none; b=WFtAHXuMYrb6dFRLzpakDDEvLsfKas+KhVjbP1Xv5geRfLcbDggaG5+5kVO71KlPg7Bwm2eNVXvWvz1usnd/WRqMLRg7oe9VzUrrhuLt+Y04hLk+51FqFCDTDoVX9q2ixDOMgHyvY2QMyeBN2gwiQgCV/qVvRy8L+W2lolZgL90= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702916982; c=relaxed/simple; bh=Xe8wWkXXZNrwy2LHj6yQNVVyn0b1gd0HXFU3DDl86y8=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=sPXOUTJ7FxdZjC/4yAt9q7AJljTBrQ5E/xnLZBqbXeo6XJMuAy7CGXClBMLtqv8kWdOISlhOhQlMnf5kaiO8qg4d0V6Ef4NOSlsojW6TlOKw5lLukif1mfryyRTqybsVVZB9qQO/keEUw5JMihFLr8dLJWWvfm784xQbXCTeh84= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id BB06C335D75; Mon, 18 Dec 2023 16:29:40 +0000 (UTC) Date: Mon, 18 Dec 2023 11:29:38 -0500 From: Mike Frysinger To: jaydeep.patil@imgtec.com Cc: gdb-patches@sourceware.org, aburgess@redhat.com, joseph.faulls@imgtec.com, bhushan.attarde@imgtec.com Subject: Re: [PATCH v3 2/3] [sim/riscv] Add support for compressed integer instruction set simulation Message-ID: References: <20231217065218.3799535-1-jaydeep.patil@imgtec.com> <20231217065218.3799535-3-jaydeep.patil@imgtec.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CcFl3hOnP/TJO2Yr" Content-Disposition: inline In-Reply-To: <20231217065218.3799535-3-jaydeep.patil@imgtec.com> X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --CcFl3hOnP/TJO2Yr Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 17 Dec 2023 06:52, jaydeep.patil@imgtec.com wrote: > Added support for compressed integer instruction set ("c"). you haven't responded to feedback in previous patches. please do that before posting new ones, or clearly document in the patch the feedback you've addressed as is standard git behavior. > --- a/sim/riscv/sim-main.c > +++ b/sim/riscv/sim-main.c > =20 > +/* Return address register. */ > +#define REG_RA 1 > + > +/* Stack pointer register. */ > +#define REG_SP 2 we already have SIM_RISCV_xxx_REGNUM. don't invent new ones. -mike --CcFl3hOnP/TJO2Yr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmWAc3IACgkQQWM7n+g3 9YGUuBAAiBo1w/kM5A94xgWI7cfJD2UlpupF05h/NjsKiPEWg/kYaPQZfKQS4sWn /HurzWiMES1netfNchwxyTd/h/YnI44HAmYIYWmNchvwULC5wBx9wqLKxLhvl3i6 GiBlXJyLxiSVJWq8nq4OkNIXr1g+IxtLuMYdRNcNqJ7TsJZi1FLUjmLKT1H5IT8s POrd+Z4zoMabQHnu/5RzlKnvHy+c87qmN56hpZDUfnyn3u8qxQOz/a7BtZW7xPFB QRz2QsslP6J1v+RHx28uQ/ioP5xHAYeeWtZVWZoufYcY8m9neZ4NS3TIkb/GsG/A RykqeYamKmhd0VcrwtuNHaUv1bZHqwNsdXnuR9iAgN5Iond8jAmH7f+M8jbGBbMI TTyvfOfjzv3h3asZI/Wb+iZI7rSI/4ATWbyV78cBO84aAMUZDh7KDmwdB15m6Ia3 kE8DIqvFYDOjNYpWHPd2NgOQLJbnlT4C7FhWkVC/kCsZT2qk17rhZRn3yNmEONS8 yqV4rhzsEnYcPscrydJA+LtSLCNakA7VcIli5ECM0erhPTBHzGvB4GdKzC0AEv7/ UB9ZG7ubHbO30JaLdzh/RMZaPgx6mqtEDAG1Mc5HY1wGwnBGcUo/n3jrG/aWavV8 Mb/xkUL+tQGa2alo8lHsUq5d9htkmqZxv21cW5g/FRFxSuA1MZQ= =oKiG -----END PGP SIGNATURE----- --CcFl3hOnP/TJO2Yr--