From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 976973858C2C for ; Wed, 20 Dec 2023 01:32:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 976973858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 976973858C2C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703035931; cv=none; b=Fw/7hKMDjchJoObmXS96jyBvPOAKgXjyED++zaF440M6yyU97uAumDaGokjuKNGm+xdndgVjDe0G7n7xEDR8QQib+DUbew+L56uxHLtEMBmt0DPu6bLrciufnQIFB0Ur1uIpavWQQbOYeqk1iYIj9q3PjhlO6Wt88ltn7tkHZfY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703035931; c=relaxed/simple; bh=52rTsm9QXFkk+AaLCnYLBsE0xV9K2CvILJlJkaJdr7Q=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=XtE0hs+aRoyvneQ5rCzE9arnSkzZ1SgAUD0kgj2Ow7Iut5VoraOGJbcQzjizIBGFxzfif9FtDGjMYK1o0EB13y4CxsXGmrtaV/AfWvcVy3tZbknHhZRUQGYe07+HopKzxd/zOzVRXmLcqxhSVuET+abBYeuz+4II4W9wBYP6iRk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 1EC3E3406C2; Wed, 20 Dec 2023 01:32:10 +0000 (UTC) Date: Tue, 19 Dec 2023 20:32:08 -0500 From: Mike Frysinger To: Jaydeep Patil Cc: "gdb-patches@sourceware.org" , "aburgess@redhat.com" , Joseph Faulls , Bhushan Attarde Subject: Re: [EXTERNAL] Re: [PATCH v2 2/3] [sim/riscv] Add support for compressed integer instruction set Message-ID: References: <20231030130042.1472535-1-jaydeep.patil@imgtec.com> <20231030130042.1472535-3-jaydeep.patil@imgtec.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0np5mR5OVbsRdH0b" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0np5mR5OVbsRdH0b Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 19 Dec 2023 06:11, Jaydeep Patil wrote: > Mike Frysinger writes: > > i haven't been keeping up with riscv specs. is the compressed extensio= n finalized ? so you're only implementing official insns in the spec ? i = don't think it's appropriate for the sim to implement vendor-specific stuff= at this point in time. >=20 > The compressed instruction set ("c") is not vendor specific. It has been = ratified. that's good. it's still an extension though and not in the base ISA. it shouldn't be available all the time, only when a compatible model is select= ed via the --model option. otherwise it should throw an SIM_SIGILL error. look at riscv/model_list.def and machs.c files. > > afaict, there is no relationship between the compression & semi-hosting= work. > > these are just two things you're working on ? so they don't really nee= d to be in the same patch series. >=20 > Yes, there is no relation between compression & semi-hosting work. The pa= tches are independent and I can re-submit them if needed. not strictly necessary, but makes it confusing when you label the patch "semihost", and there's debate on that particular topic. > > i'm missing something ... why does there need to be tests in gdb at all= here ? >=20 > Purpose of riscv-insn-simulation.exp is to test both C extension and semi= -hosting. However, I have also added sim specific tests in patch v3. none of the semihost logic lives in gdb. it's entirely in the sim code. there's no need to have any test logic added to gdb -- it can all be in the sim tree. -mike --0np5mR5OVbsRdH0b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmWCRBgACgkQQWM7n+g3 9YHUYw//VlXGH/i22dlh7MWdxnX/YjApM3aUyEGq42kYuR66y7+wYv7sz6Zkh5MF KVIqkBcNrBvtjP7b4vEIDm7/UC6x3PD5b/wEOyJxZvi3QJlOLyc8M9tEtyrx+pDz SRZVLhgVDUr59MFHr8ODMsqdnpEybQwFdsGHPlGsJ+mya6OYISpzxcW+MLWPyEjr qwSepqpbdYKgpdTu8rpUL+WpPzEs3NifYcDSlX4fTfuzw+sItqjaB3f2naMQXLhT ZChTr97j9lNRWrNgF28HJ/xwu0MMYnBxkVLuZQom8uzhFqWFTFBufg3Z0hTc9eCn +uByZxTKMsVwYgx1zOj0377+VzbGcbJJLMP7Uu1E5eu0iKhXGMgd0+Ox4Gfb4nN8 I7vC0e6XDgmPLFiRdcIaK7XA8xIW/5BDbNASiYPfi1fZ1PHar1pzLWTIEAT4clNe In6/rzLKjBWrEo4ohb/exC3qbr8aBxZXuIcyrGKwLeJ94NPE/H42HpUFbDWXNFZq zi9TRFxXMSwreHtEnrrvCgXRndbb2lvGZ+aAMtsYjc09KBUnV78KA8kTHDSmL+Wm HBTm6Jakbd+mTO98PTCqmjsehA/5HHgm5WpamOckGAXw2O8F693TXt79cQ3cHDjn LYDOxLfMCUFR7sppNInp6d2cslB3hVk3XF5riFSgoH4sf5aGppw= =o4jW -----END PGP SIGNATURE----- --0np5mR5OVbsRdH0b--