From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 480083858C74 for ; Tue, 9 Jan 2024 17:42:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 480083858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 480083858C74 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704822124; cv=none; b=MsM1xqDVDt1ACExzK81nuqOtkKCUPGr3TUactnOGVLIOVsRyenbsGHREOHabnTlxuXfL6Am9AxuB/C6sUyqCkxA1HWXJ99vbt8Kwy1F6ZIjNtTz+tTl1R2rAfZNJOJ4MbvoqbAaIEPQQxI6MEA3BFmtW+YD3bacWSlAFnn0e0Xk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704822124; c=relaxed/simple; bh=yizSyNsedXmUjpw+WgRWXOwxGU+x2K0ebBToJ50o+58=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=FpS5gqBCQ+btN12j2S1n7Nynz3u+3yG3f1+S1IFSgfh1MWUgh9n1DFWog7N1+j42b8PMYxAaLZ2UHseXCSAobmVrmzrPl2E7Rb9qNGD3SJpvNhRMkaPgvsawQah8FBo5Qoc7++98zFB4QsBCnwUtPIrQ6lpsTPNlLZSKkNQ811c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 930FB343341; Tue, 9 Jan 2024 17:42:00 +0000 (UTC) Date: Tue, 9 Jan 2024 12:41:58 -0500 From: Mike Frysinger To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH/committed 2/8] sim: ppc: replace filter_filename with lbasename Message-ID: References: <20240101232219.3003-1-vapier@gentoo.org> <20240101232219.3003-2-vapier@gentoo.org> <87a5pewp73.fsf@tromey.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ho72ZvD9e19mL4Gt" Content-Disposition: inline In-Reply-To: <87a5pewp73.fsf@tromey.com> X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --ho72ZvD9e19mL4Gt Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 09 Jan 2024 07:34, Tom Tromey wrote: > >>>>> "Mike" =3D=3D Mike Frysinger writes: >=20 > Mike> The lbasename function from libiberty provides the same API as this > Mike> custom function. The common/ code already made the switch, so make > Mike> the same change to the ppc code to avoid target duplication. >=20 > When updating and rebuilding in an existing tree, some patch -- I guess > probably this one, I didn't bisect -- caused a build failure in sim/ppc > because filter_filename was missing. Removing sim/ppc/*.o and > rebuilding fixed it, but I suppose this means there is a missing > dependency somewhere. ppc/ used to generate a filter_host.c file in the output dir, and compile t= he =2Eo from that. it switched to using the igen/filter_host.c in the source = dir. when i've migrated code like this, i haven't left behind clean rules to del= ete files that only mattered to old builds since any new builds would never see that stuff. but it means bisect/incremental (re)builds across that timespan might break. i don't know what the general policy is in the tree for these cases, but it seems like we just don't bother. also a lot of sim rules rely on VPATH to locate sources. e.g. the makefiles write ppc/foo.c instead of $(srcdir)/ppc/foo.c. the only time we really use $(srcdir) is with generated files we commit to the tree. i think this patt= ern is standard in the binutils-gdb tree. but it also contributes to increment= al (re)build failures like this. -mike --ho72ZvD9e19mL4Gt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmWdhWYACgkQQWM7n+g3 9YGLjhAAwH5too1g5FVyAN9ORrpnKltPsBpZzgIiuIk4+JI2eX6VH3PxYO6bcADA itVN9/Mfd7o+MujIXj0jUOcpbOdONTbIXdNuG4lAlrfPs0/5nlRYiFPuh6qMpitc oYfq6G3qX/3XV0qBjdv6rv1g3hTzZKE5u5q+UraO8wVBSu7Z20XG82HIP5Gjkaeq KyxVxhdbpp89ELoBsNQ5m7PLg1nG/xieyC0o0ab6DNVRoFm/Y5HM+H/UEJmwDgT/ tmkt26EgiqarHTLSt2/UBKJWhJjNb/GwwQN0eDY3jBsm9RTrM1B9dPqiND1m4kOG rFfwzTAK58qrLbeuZcPjrk0NuXNkU+TqG/FgEfrx0mXP6H5IYBkAPWwQ5gDf5/vv Vs7zO1h/DpeDO8ngtta/N5g1duZFUn3buVRyf0RBnTGtYluohi3KjTfiAxID0rjz W4kAXchkA1+6CSZPUn/aFdELti42Efuc03mcHDnXv1MOrns/M8NvzhGvnD3Qltl7 NYfo3WLdsWKwOMXjnDQkIx9+0dVqQqDyMQwm15wKZjnuF+XUUqiFt7fSuW8cfa2P 7+mc5ZaRrzJKFv9es4SgxT7hBsciJlWd958yt0Hr6gq2d2Ni5xtOJRsKFn32ZIUK RJoxcxLvpo581z1MiW1SZ8osHsYnd4dnr8VCG24ZGbcEtZEM4wQ= =Xxnw -----END PGP SIGNATURE----- --ho72ZvD9e19mL4Gt--