On 04 Jan 2024 04:24, Jaydeep Patil wrote: > Could you please review this patch? i was mostly being lazy and waiting on the first one to merge. i assume Andrew needs to sign off on that as i don't usually touch opcodes/. also, can you stick to normal "tag:" commit summary style, not "[tag]" ? git treats "[...]" text specially and likes to discard it in some cases which makes merging your patches difficult. so use "sim: riscv:", not "[sim/riscv]". -mike