Re: Optionally print source code to gdb console window

[Bob Rossi <bob@brasko.net>]

On Wed, May 08, 2024 at 09:46:16AM -0600, Tom Tromey wrote:
> >>>>> "Bob" == Bob Rossi <bob@brasko.net> writes:
> 
> >> Perhaps 'set source open' could be extended to have a new value.  Or
> >> perhaps some other 'set source' sub-option could be made.  I'm afraid
> >> that normally we bikeshed option names a bit.
> 
> Bob> I think it's this behavior of gdb i want to suppress,
> Bob> https://sourceware.org/gdb/current/onlinedocs/gdb#Source
> Bob> "When your program stops, GDB spontaneously prints the line where it
> Bob> stopped"
> 
> Bob> I'm looking for a way to control printing source lines when printing
> Bob> frame information? (I'm modifying do_print_frame_info)
> 
> Bob> Something like 'set frame print_source off' might make sense to me.
> Bob> Just a thought.
> 
> How about adding a new value to "set print frame-info"?
> Like "set print frame-info nothing"?

I saw in the NEWS file,
    show print frame-info
      This controls what frame information is printed by the commands printing
      a frame.  This setting will e.g. influence the behaviour of 'backtrace',
      'frame', 'stepi'.  The python frame filtering also respect this setting.
      The 'backtrace' '-frame-info' option can override this global setting.

So i tried out how frame-info impacts the bt command,
    (gdb) set print frame-info short-location
    (gdb) n
    main (argc=1, argv=0x7fffffffe098)
    (gdb) bt
    #0  main (argc=1, argv=0x7fffffffe098)
    (gdb) set print frame-info auto
    (gdb) bt
    #0  main (argc=1, argv=0x7fffffffe098) at test_main.cpp:47
    (gdb) 

The only request i've had, is not to print source lines automatically to
the console, because cgdb already displays them in a source view.
This is how cgdb worked with annotations, so people were familiar 
with that behavior in cgdb, until i upgraded to mi.

I don't think people want gdb's behavior changed under cgdb.
If they prefer special settings for 'print frame-info', they should
probably be allowed to keep them and not have cgdb hijack them.

A new option, but separate from the existing frame-info command, as to
not impact other areas of gdb.
  set print frame-info-source-line off
This is very similar to your approach, however, it lets the user choose
whatever they want with print frame-info, and then it lets cgdb "subtract" the
source-line printing from the console in only that case (and not bt case).

What do you think about this crazyiness?

Thanks,
Bob Rossi