public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: Simon Marchi <simark@simark.ca>, Eli Zaretskii <eliz@gnu.org>,
	gdb-patches@sourceware.org,
	Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH] gdb/doc: use silent-rules.mk in the Makefile
Date: Sun, 26 May 2024 11:20:42 -0700	[thread overview]
Message-ID: <ZlN9et3OsIgWPf6Z@adacore.com> (raw)
In-Reply-To: <87jzk4ryc3.fsf@redhat.com>

Hi Andrew,

> > commit 13baf7f097593b9d877036f55fb3d9c2d443ea38
> > Author: Andrew Burgess <aburgess@redhat.com>
> > Date:   Fri Apr 12 17:47:20 2024 +0100
> >
> >     gdb/doc: use silent-rules.mk in the Makefile

I think this patch unfortunately broke the install phase of the doc
when building from a source package. To reproduce, first create
a tarball file by executing the following command from the root
of the binutils-gdb repository:

    $ ./src-release.sh gdb

This will create a .tar file at the root of the repository
(and it creates a lot of other files, so you want to do this in
a copy of your repository, if you don't want to have to deal
with the pollution)

Then, from a separate directory, first unpack the tarball sources.
And then, create a local build directory, and from that directory,
configure and build GDB - I did:

    $ CFLAGS='-g' CXXFLAGS='-g' ../gdb-15.0.50.20240508/configure --prefix=/[...]/ins
    $ make -j8

Once you've done that, try...

    $ make install

... and you should see the error I'm getting:

    | [...]
    |   TEXI2POD gdb.pod
    | cannot find GDBvn.texi at ../../../gdb-15.0.50.20240508/gdb/doc/../../etc/texi2pod.pl line 251, <GEN0> line 16.
    | make[5]: *** [Makefile:663: gdb.pod] Error 2

I don't know what the root of the problem is, but I think one thing
that is happening now that should not be happening is the fact that
(I think) it is trying to re-generate the gdb.1 man page, whereas
gdb.1 is already present in the sources. With the gdb-14.2 release,
from what I've seen, the install simply consists in copying gdb.1
from source dir to install dir.

Do you think you could take a look? And once we have a fix, could you
backport it to the gdb-15-branch? I think we'll want the fix in that
branch before we create the first pre-release.

Thank you!
-- 
Joel

  reply	other threads:[~2024-05-26 18:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-12 17:00 Andrew Burgess
2024-04-12 18:31 ` Eli Zaretskii
2024-04-12 22:32   ` Andrew Burgess
2024-04-13  7:02     ` Eli Zaretskii
2024-04-15 13:55       ` Andrew Burgess
2024-04-15 14:18         ` Simon Marchi
2024-04-16  7:48           ` Andrew Burgess
2024-04-16  8:47             ` Andrew Burgess
2024-04-16 15:01               ` Simon Marchi
2024-04-17 21:00                 ` Andrew Burgess
2024-05-08 17:46                   ` Andrew Burgess
2024-05-26 18:20                     ` Joel Brobecker [this message]
2024-05-26 22:02                       ` Andrew Burgess
2024-05-26 22:58                         ` Andrew Burgess
2024-05-28 15:25                           ` Tom Tromey
2024-04-15 14:37         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZlN9et3OsIgWPf6Z@adacore.com \
    --to=brobecker@adacore.com \
    --cc=aburgess@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).