From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailsec210.isp.belgacom.be (mailsec210.isp.belgacom.be [195.238.22.106]) by sourceware.org (Postfix) with ESMTPS id 8E9B33858C83 for ; Wed, 11 Jan 2023 10:58:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8E9B33858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=skynet.be Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=skynet.be DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=rmail; t=1673434708; x=1704970708; h=message-id:subject:from:to:date:in-reply-to:references: mime-version:content-transfer-encoding; bh=m940VNFd7Nil0myy0m9VTQm+/9ebY6BvVEnomh3SUo4=; b=My0XB3HL28ONaOxTUULPlMQB+H1LT3lDEtVPovpKSWTiOz+pJ1w9G7Dw oKZODQ7f7S9cZ9Nx0Qkd2qd5fBCGm+AZWI3xZ7am78+oZMQ1s2jcLyizl o2vZKkoN3PNIOr7d0h0emNrpnx+he+du8WexIekIwnT1PeJ02g5TREZJ1 8=; X-ExtLoop: 1 X-IPAS-Result: =?us-ascii?q?A2BRAQB8lb5j/1uGgG0NTYEJCYsgkSKdUIFqDwEBAQEBA?= =?us-ascii?q?QEBAQlEBAEBhQUChRYmOBMBAgQBAQEBAwIDAQEBAQEBAwEBBgEBAQEBAQYEA?= =?us-ascii?q?YEchS+CfikBg3UBAQEDIw8BVgsOCgICJgICVwYBt1J6gTKBAYRzmmWBZ4EUL?= =?us-ascii?q?IkNg2OEMTeBVUSEDzA+hCqDcYJnBJoegT18gScOgUk8HDcDGSsdQAMLbQpAN?= =?us-ascii?q?QsLSysaGweBCiooFQMEBAMCBhMDIAINKDEUBCkTDScmawkCAyFhBQMDBCgtC?= =?us-ascii?q?SEfBxURJDwHVjcBBAMCDx83BgMJAwIfTnIuERMFAwsVKkcECDYFBhw2EgIID?= =?us-ascii?q?xIPBiZDDkI3NhMGgQcLDhMDUIFPBC+BXQoGUZ0ceYEhlTuOXaEoNAeDcoFKB?= =?us-ascii?q?gyfCDKpJ5ZTdSCnZoF5gX5tgztRKI5XjhqBLwIHAQoBAQMJjCMBAQ?= IronPort-PHdr: A9a23:xG+tCBKv/wzmhyvz+dmcuEphWUAX0o4c3iYr45Yqw4hDbr6kt8y7e hCFuLM80BSQDM3y0LFttan/i+jYQ2sO4JKM4jgpUadncFs7s/gQhBEqG8WfCEf2f7bAZi0+G 9leBhc+pynoeUdaF9zjaFLMv3a88SAdGgnlNQpyO+/5BpPeg9642uys+5DfeQFFiTWybb9vK Bi9sBncuNQRjYZ+Jak9zQfErGFVcOpM32NoIlyTnxf45siu+ZNo7jpdtfE8+cNeSKv2Z6s3Q 6BWAzQgKGA1+dbktQLfQguV53sTSXsZnxxVCAXY9h76X5Pxsizntuph3SSRIMP7QawoVTmk8 qxmUwHjhjsZODEl8WHXks1wg7xdoBK9vBx03orYbJiIOPZiYq/ReNUXTndDUMlMTSxMGoCyY ZYPAeQfM+hXrYf9qEcAohSxCgehH//vxzxSi3PqwaE3yeYsHAfb1wIgBdIOt3HUoc3vOqcSU OC1yKjIzS3bb/xIxDzy6JLHcgomofGVQLJwcNTeyVM0FwjYiViQsYzlPzKR1uQMq2ib9/RvW fihimE9sQFxpSGvxtotiobXnIIV0UvJ9T56wIc1I923VlJ7bcS/H5ROriyXMZZ9Tcw+TW9yo ik61qEGtoChfCgM0Jkqxh7SZfKIfYSW4B/uW/idLSt3in9neL+yhwu+/Fa9xuD+SMS4zUhGo jdbn9TMqn0Ayx3e58aZRvZz4Eus3SqD2gbO4e9HOUA5jbfXJ4Ilz7Iqi5Yfr0fOEjXrlEj4g 6KabEEp9vWu5u/6eLvpvIWcOJVxigzmN6QundGwDvogPwgVWmib5fy81Lr+/U3lWLlKjuM5k q3esJ3CIcsXu6q0DxFP3oo+6huyDC2q3MkCkXUaKF9KfgqLj4nvO17QPPD1Feqzj0ionTtx2 vzKIL7sDo/QInXNn7rtZ7Jw51NExAo2199f5pZUCr8bIPL0X0/8rMTYDh84MwywwubnEM192 Z0EVWOBGKCZKqTSsUaV5uIuPeaMfpQVtS3mK/gm5//ui2E2mUMHcaayw5QbcHa4Ee9+LEWDf XXsmssBEXsNvgcmUuDmkEeCXiJLZ3auQ6I84Sk2B5i9AofeXICtj6KO3DygHpBNfGBJFE2DE XfyeIWYQfsDdCWSIsp5njweSbehU5Mh1Q2ptALixLpoM/Hb9jQAtZ35yNh6++3Tmg8p9TFvF MSd1HyNT3tokWwWST45xrp/rlJnxleEy6h4jK8QKdsGzvVFSAolfbTB1eN3EMu6DgvLY82GR U29as+rDTE4UpQ6xNpYJw5FG9Smjwjb0mKVCqUSjqGKCYYvurzd1jDeK8w403/a36kslBFyT cdFcHWvmqV/+hP7HInUiU6UiK+weOIbxiGbp0mZym/bhEFZVA9oSaiNYnkFYVLLrNnj/QuWV 7+vDbU/KgYH1seYLbJXa9Dzln1dR+blNciYaW/nyDT4PgqB2r7ZNNmiQG4axiiITRFcy2gu IronPort-Data: A9a23:fzmg06BRCiZUARVW/0/iw5YqxClBgxIJ4kV8jS/XYbTApDMg1zECz 2ZLCmvVO63eazb8fYtyPNyyoBtX6pDXz4RjOVdlrnsFo1CmCSbm6XV1Cm+qYkt+++WaFBoPA /02M4WGdoZtJpPljk/FGqD7qnVh3r2/SLP5CerVUgh8XgYMpB0J0HqPoMZkxN826TSFK1nV4 4iq+pSGYAbNNwNcawr41YrS8HuDg9yv4Fv0jnRmDdhXsVnXkWUiDZ53Dcld+FOhH+G4tsbjL wry5OnRElHxpn/BOfv5+lrPSXDmd5aJVeS4ZtW6bID56vRKjnRaPq/Wr5PwY28P49mCt4gZJ NmgKfVcRC9xVpAgltjxXDEID3t9BJNd2YbpPHGx6c2z5B3IaFvjlqAG4EEeZeX0+85EWDAUs 6VGeHZUKEnSsopawpriErgq355zapCwYMVO4xmMzhmAZRoiaYjDQqHL/cdVmig5nMdXAPfTf dExcjl+ahncJRdCUrsSIMNuwbn33imXnztwgn/PqfU8/kXvnFZI9aGzd/iPSvbbfJAA9qqfj iecl4jjOTkTPsGFxjee6Vq2i+PPlD+9U4UXfJW3+vQvmFSPzWweEzUNUkahqvSmg1SzHdVFJ CQpFjEG/PF0rRf3C4CnD1jh+C/CtxIHX59cAut86RqVjKDZ5wmQDW8BCDRMADA7iPILqfUR/ gfht7vU6fZH6dV5lVr1GnyoQf9e9MTbwaLupcPJcOfd3+TenQ== IronPort-HdrOrdr: A9a23:IkBX2qukAUJkgAFWkYr7rx7m7skDrdV00zEX/kB9WHVpm6uj5q KTdZUgpHzJYVMqM03I9urgBED+ewKlyXcY2+Ys1M6ZLXPbUTKTXfxfBOjZowEIeReOitK1vJ 0IG8JD4fLLfD1HZK3BjjVQfexN/DFSmJrY/ts2t00BceicUdAG0+8oYjzrdnGfuWF9dPwE/I D23Ls/mwad X-IronPort-Anti-Spam-Filtered: true Received: from 91.134-128-109.adsl-dyn.isp.belgacom.be (HELO [192.168.1.19]) ([109.128.134.91]) by relay.proximus.be with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2023 11:58:24 +0100 Message-ID: Subject: Re: [RFA] Fix use after free caused by redefining a python prefix cmd that has aliases. From: Philippe Waroquiers To: Andrew Burgess , Philippe Waroquiers via Gdb-patches Date: Wed, 11 Jan 2023 11:58:24 +0100 In-Reply-To: <87fscih9e0.fsf@redhat.com> References: <20221226170823.2744157-1-philippe.waroquiers@skynet.be> <87fscih9e0.fsf@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1+deb11u1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks for the comments, I will handle them (time permitting, this is an evening/weekend activity). Just a small initial feedback on the addition of FUN argument: On Tue, 2023-01-10 at 12:16 +0000, Andrew Burgess wrote: > >  static struct cmd_list_element * > >  do_add_cmd (const char *name, enum command_class theclass, > > + cmd_simple_func_ftype *fun, > > A brief description of what FUN is for should be added to the comment > above do_add_cmd. In fact, I should have indicated in the commit msg that I have just added back the FUN argument that was there in the past, but when it was removed, the comment was left there. I will dig a little bit more in depth to see when/why FUN was removed and double check that the existing comment for FUN still correctly describes what it now does (again?). > Thanks Philippe