From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id BC0BC3858412 for ; Tue, 17 Oct 2023 00:22:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BC0BC3858412 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BC0BC3858412 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=96.47.72.81 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697502139; cv=pass; b=cRpbVKxFPk1z4S3f526bB9fN1rgZV9gGDOFXvc4lmdpNczSeF3KsI2p45auiBECow+SClJxAzE3qDCuOpU/4jHhtyU59TblIEZuJODKGOocQW6m3RlUUXPD75cNJLywtiNNqWVWSDSH3lwZxjeCFSuLyjYuAHCh3HC5aBDcMCzo= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697502139; c=relaxed/simple; bh=9XxrBcxzNEATj6C27+W6Teo60Sz0paSyrsRr3qe205M=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=nsd+EAR2n5Qizw7rQdvLeAzKa0REGQbCybjiVrfy4vr7VcES58gRjh5ahMJo8lPbMBXcX5LcSvaqSlastxUEYp1qPI30B9Ws/KYrhbRrnT4PIHMGYGmZkO/ug1QIRLdKmBJR45sYjoBDeGKEjU7d42pe8ZIcsKzCrJFrBP9fqv4= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4S8ZRt0X1fz3dqD; Tue, 17 Oct 2023 00:22:18 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S8ZRs6v4yz3LKG; Tue, 17 Oct 2023 00:22:17 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697502138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IHbmoo0rp3rS0DMHM5p2DmfwXnSnH2+6gfkKC5rfaqI=; b=PgIiBawmfDzizYURuqOPsMK+yjr+mFPBuRdFecDH8iWl7CRUW5PDppOCDSahfBYzbidiYQ xgetz8/yCaxgJfYNflFR0dZ4GXTqAjkJmWS/hvrCx9CKLB49VduAEwEq0q+T6uitlfKGv8 ML3eZnH4Nz0bgK2mFrpwJ8n/q+ZhiRnj/60tDf9Q54JuDF3wboYvsI/xfeEYLZbO+RairC 8p99tCgY2qA/vQxiDEvsDJOnpTlED9Lks/vpezHXzx7mX3K+HVkZTP7d8rCjpLjsTOqi2T HMnOQF4BPbSynloLPrmbygcyixp4QOW8CkbjgpuX26+mnjGnRkM31DoK5u5XdA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697502138; a=rsa-sha256; cv=none; b=Ys1fraJSLd11PZouzY2/IeDiLcOar5QOY7fcsCXFf/XF+XXsXR9I5u+D4CLMQlZKAtgLye r1OCKbJNK2jQUwwo8YlNVLzaaTWh3ew6I3jVDajfV7tSS+6AwqEwE+flkQxQOF3KX8kkm9 WLEiC2EWD/lzXVM1EaPfRblpoiUjvNi7fFCmp8iz6QAwaag8D2I4xm+DX4ldR2t3mkRg8o qtabcp7Jw+ovuXXIQg0PBQFDHq5Ufz84Jz0Pt9j6SuWdua68cM0YO9WY7X6mxJB2Fhe6fj eNSi+F9adLIul9/ia3KQZFXW4SIKHThWv2VDFAi0JpzoDJSQPmlNTX4THf84tg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697502138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IHbmoo0rp3rS0DMHM5p2DmfwXnSnH2+6gfkKC5rfaqI=; b=jENJBbm47Ls8RpP6knaiZPVBAIaZ5kbVeLFoCsV1TA5pQpHN98+GcXaA2R/lSH83cd5Ymg kjv+J9a5kOEFpjtLjuCaJbAdtGDdrsEpx3dUls553MFCpbY+bTYOzN+aoICA1dIpaRcSww uumNnciaQww7pO6gajtHdkIw14Mb3IRwdoaYCAznba7fhPRW+Uq+MnrI3fjfK032hzncZR T1TnjFfKREm/M5N7LGoQle4PZnJTW7eS0ZjAhM80tdeXBR4tAWqwk2S6vJzfgvATGq6hNt IQ7ygUdzsXwA41Fkp+SNZvckNO9xip6VbZp35sJDhzoZGyC5VTu0oA2x5kFEjA== Received: from [IPV6:2601:648:8683:39a0:f055:f679:76c4:bebe] (unknown [IPv6:2601:648:8683:39a0:f055:f679:76c4:bebe]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4S8ZRs4Gg2ztxL; Tue, 17 Oct 2023 00:22:17 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Mon, 16 Oct 2023 17:22:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [RFC 06/13] nat/x86-cpuid: Add a function to build the contents of a NT_X86_CPUID note Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20231009183617.24862-1-jhb@FreeBSD.org> <20231009183617.24862-7-jhb@FreeBSD.org> <35527e3a-08ec-49c4-9917-127d94ca2111@polymtl.ca> From: John Baldwin In-Reply-To: <35527e3a-08ec-49c4-9917-127d94ca2111@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/11/23 9:41 PM, Simon Marchi wrote: > > > On 2023-10-09 14:36, John Baldwin wrote: >> +/* See x86-cpuid.h. */ >> + >> +void >> +x86_cpuid_note (gdb::unique_xmalloc_ptr &buf, size_t &len) >> +{ > > I think it would be a bit simpler to make this return a gdb::byte_vector. Yes, thanks. I couldn't remember the name of this class. -- John Baldwin