From: Simon Marchi <simark@simark.ca>
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/5] gdb/testsuite/: Use -qualified in runto_main / mi_runto_main
Date: Tue, 13 Oct 2020 14:06:30 -0400 [thread overview]
Message-ID: <a0272fc0-c9e9-a05a-47ca-943a2f0fcda5@simark.ca> (raw)
In-Reply-To: <20201012004732.22999-4-pedro@palves.net>
On 2020-10-11 8:47 p.m., Pedro Alves wrote:
> diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-support.exp
> index 732aed27b27..693c7d2c467 100644
> --- a/gdb/testsuite/lib/mi-support.exp
> +++ b/gdb/testsuite/lib/mi-support.exp
> @@ -1056,7 +1056,7 @@ proc mi_run_to_main { } {
> # -1 if test suppressed, failed, timedout
> # 0 if test passed
>
> -proc mi_runto_helper {func run_or_continue} {
> +proc mi_runto_helper {func run_or_continue {qualified 0}} {
For new options, I'd suggest using the parse_args procedure, instead of
using arguments with default values. That makes it nicer when a
procedure has multiple optional arguments and want to specifiy just one
(that isn't the first one).
So a call to mi_runto_helper would look like:
mi_runto_helper main run -qualified
Otherwise, LGTM.
Simon
next prev parent reply other threads:[~2020-10-13 18:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 0:47 [PATCH 0/5] runto_main and -qualified Pedro Alves
2020-10-12 0:47 ` [PATCH 1/5] 'runto main' -> 'runto_main' throughout Pedro Alves
2020-10-13 17:57 ` Simon Marchi
2020-10-12 0:47 ` [PATCH 2/5] Introduce mi_runto_main Pedro Alves
2020-10-13 18:00 ` Simon Marchi
2020-10-12 0:47 ` [PATCH 3/5] gdb/testsuite/: Use -qualified in runto_main / mi_runto_main Pedro Alves
2020-10-13 18:06 ` Simon Marchi [this message]
2020-10-13 21:33 ` Pedro Alves
2020-10-12 0:47 ` [PATCH 4/5] gdb/testsuite/: Use "-qualified" in explicit "break main", etc Pedro Alves
2020-10-13 18:07 ` Simon Marchi
2020-10-12 18:56 ` [RESEND][PATCH 5/5] Eliminate mi_run_to_main, introduce mi_clean_restart Pedro Alves
2020-10-13 18:19 ` Simon Marchi
2020-10-13 21:36 ` Pedro Alves
2020-10-14 8:40 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0272fc0-c9e9-a05a-47ca-943a2f0fcda5@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).