From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 824873858408 for ; Tue, 28 Sep 2021 14:33:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 824873858408 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 18SEXGeX022653 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Sep 2021 10:33:21 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 18SEXGeX022653 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4E5BF1EDDB; Tue, 28 Sep 2021 10:33:16 -0400 (EDT) Message-ID: Date: Tue, 28 Sep 2021 10:33:15 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Subject: Re: [PATCH v5 1/9] gdb: Move construct_inferior_arguments to gdbsupport Content-Language: en-US To: Michael Weghorn , Simon Marchi , gdb-patches@sourceware.org References: <20200429111638.1327262-1-m.weghorn@posteo.de> <20200520162115.713005-1-m.weghorn@posteo.de> <09d143d7-f003-ee72-7922-7102772b4f08@posteo.de> From: Simon Marchi In-Reply-To: <09d143d7-f003-ee72-7922-7102772b4f08@posteo.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 28 Sep 2021 14:33:16 +0000 X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Sep 2021 14:33:40 -0000 On 2020-05-26 02:17, Michael Weghorn wrote: > On 25/05/2020 17.42, Simon Marchi wrote: >> On 2020-05-20 12:21 p.m., Michael Weghorn via Gdb-patches wrote: >>> This moves the function construct_inferior_arguments from >>> gdb/inferior.h and gdb/infcmd.c to gdbsupport/common-inferior.{h,cc}. >>> While at it, also move the function's comment to the header file >>> to align with current standards. >>> >>> The intention is to use it from gdbserver in a follow-up commit. >>> >>> gdb/ChangeLog: >>> >>> 2020-05-13 Michael Weghorn >>> >>> * infcmd.c, inferior.h: (construct_inferior_arguments): >>> Moved function from here to gdbsupport/common-inferior.{h,cc} >>> >>> gdbsupport/ChangeLog: >>> >>> w020-05-13 Michael Weghorn >>> >>> * common-inferior.h, common-inferior.cc: (construct_inferior_arguments): >>> Move function here from gdb/infcmd.c, gdb/inferior.h >> >> I've pushed the whole series, we can take a look at improving how inferior arguments >> are passed to gdb_run_cmd as a separate change. >> >> Thanks a lot for your contribution and perseverance! >> >> Simon > > > Thanks for pushing and all help along the process! > > Michael > Hi Michael, Can you take a look at this bug? https://sourceware.org/bugzilla/show_bug.cgi?id=28392 Thanks, Simon